lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LUCENE-1979) Remove remaining deprecations from indexer package
Date Wed, 14 Oct 2009 06:01:31 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765414#action_12765414
] 

Uwe Schindler edited comment on LUCENE-1979 at 10/13/09 10:59 PM:
------------------------------------------------------------------

There are two possibilities:

- Changing the backwards branch main code to change this method
- remove this test

I think both possibilities has pros and cons, I tend to the first, because: As you changed
the method also in 3.0 trunk, you have to put a backwards incompatibility entry into changes.txt
(because we have detected it with the test). In this case it is also valid to change the bw
branch code and not only tests.

(I only looked over the patch, but didn't test it, to find the same things like yesterday.
Didn't read all the comments, sorry).

      was (Author: thetaphi):
    There are two possibilities:

- Changing the backwards branch main code to change this method
- remove this test

I think both possibilities has pros and cons, I tend to the first, because: As you changed
the method also in 3.0 trunk, you have to put a backwards incompatibility entry into changes.txt
(because we have detected it with the test).

(I only looked over the patch, but didn't test it, to find the same things like yesterday.
Didn't read all the comments, sorry).
  
> Remove remaining deprecations from indexer package
> --------------------------------------------------
>
>                 Key: LUCENE-1979
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1979
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Index
>            Reporter: Michael Busch
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: lucene-1979-bw.patch, lucene-1979.patch, lucene-1979.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message