lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Updated: (LUCENE-2002) Add oal.util.Version ctor to QueryParser
Date Thu, 22 Oct 2009 20:58:59 GMT


Michael McCandless updated LUCENE-2002:

    Attachment: LUCENE-2002-29.patch

New patch attached.  All tests pass.  Changes:

  * Fixed the "patch" -> "match" typo

  * Fixed build.xml to make 2 autogen'd (by JavaCC) public QueryParser
    ctors protected, and added unit test to assert this

  * Added Version matchVersion param to all (I think!) contrib
    analyzers that instantiate either StandardTokenizer (to manage
    changing the "fix invalid acronym" setting across versions), or
    StopFilter (to manage "enable pos incr" setting across versions),
    or, both, and threaded it down to StandardTokenizer & StopFilter

I didn't add Version to StopFilter nor StopAnalyzer; I think it's
better to up-front require the "enablePositionIncrements" to their

> Add oal.util.Version ctor to QueryParser
> ----------------------------------------
>                 Key: LUCENE-2002
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.9, 3.0
>            Reporter: Uwe Schindler
>            Assignee: Michael McCandless
>             Fix For: 2.9.1
>         Attachments: LUCENE-2002-29.patch, LUCENE-2002-29.patch
> This is a followup of LUCENE-1987:
> If somebody uses StandardAnalyzer with Version.LUCENE_CURRENT and then uses QueryParser,
phrase queries will not work, because the StopFilter enables position Increments for stop
words, but QueryParser ignores them per default. The user has to explicitely enable them.
> This issue would add a ctor taking the Version constant and automatically enable this
setting. The same applies to the contrib queryparser. Eventually also StopAnalyzer should
add this version ctor.
> To be able to remove the default ctor for 3.0 (to remove a possible trap for users of
QueryParser), it must be deprecated and the new one also added to 2.9.1.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message