Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 25532 invoked from network); 8 Sep 2009 17:48:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Sep 2009 17:48:20 -0000 Received: (qmail 9638 invoked by uid 500); 8 Sep 2009 17:48:19 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 9542 invoked by uid 500); 8 Sep 2009 17:48:19 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 9532 invoked by uid 99); 8 Sep 2009 17:48:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2009 17:48:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2009 17:48:17 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 742DC234C044 for ; Tue, 8 Sep 2009 10:47:57 -0700 (PDT) Message-ID: <2144417594.1252432077471.JavaMail.jira@brutus> Date: Tue, 8 Sep 2009 10:47:57 -0700 (PDT) From: "Doron Cohen (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-1900) Confusing Javadoc in Searchable.java In-Reply-To: <1109789434.1252422537563.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-1900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752637#action_12752637 ] Doron Cohen commented on LUCENE-1900: ------------------------------------- {quote} stripping: "Called by search code to compute term weights." Sounds like your not opposed to that? {quote} Yes, I agree, go ahead... While looking at this though, how about other "Expert" and "called by" javadoc comments in this class? - like the one in doc(int i) - I am not sure what's so expert about it..? Also there are 3 more 'called by' javadoc comments in that class, are they really needed? > Confusing Javadoc in Searchable.java > ------------------------------------ > > Key: LUCENE-1900 > URL: https://issues.apache.org/jira/browse/LUCENE-1900 > Project: Lucene - Java > Issue Type: Bug > Components: Search > Affects Versions: 2.9 > Reporter: Nadav Har'El > Assignee: Mark Miller > Priority: Trivial > > In Searchable.java, the javadoc for maxdoc() is: > /** Expert: Returns one greater than the largest possible document number. > * Called by search code to compute term weights. > * @see org.apache.lucene.index.IndexReader#maxDoc() > The qualification "expert" and the statement "called by search code to compute term weights" is a bit confusing, It implies that maxdoc() somehow computes weights, which is obviously not true (what it does is explained in the other sentence). Maybe it is used as one factor of the weight, but do we really need to mention this here? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org