Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 77535 invoked from network); 16 Sep 2009 20:08:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 16 Sep 2009 20:08:26 -0000 Received: (qmail 55570 invoked by uid 500); 16 Sep 2009 20:08:25 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 55481 invoked by uid 500); 16 Sep 2009 20:08:25 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 55473 invoked by uid 99); 16 Sep 2009 20:08:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Sep 2009 20:08:25 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [194.109.24.37] (HELO smtp-vbr17.xs4all.nl) (194.109.24.37) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Sep 2009 20:08:12 +0000 Received: from k8u.localnet (porta.xs4all.nl [83.163.165.214]) by smtp-vbr17.xs4all.nl (8.13.8/8.13.8) with ESMTP id n8GK7q1W077990 for ; Wed, 16 Sep 2009 22:07:52 +0200 (CEST) (envelope-from paul.elschot@xs4all.nl) From: Paul Elschot To: java-dev@lucene.apache.org Subject: Re: [jira] Commented: (LUCENE-1911) When using QueryWrapperFilter with CachingWrapperFilter, QueryWrapperFilter returns a DocIdSet that creates a Scorer, which gets cached rather than a bit set Date: Wed, 16 Sep 2009 22:07:50 +0200 User-Agent: KMail/1.11.2 (Linux/2.6.28-15-generic; KDE/4.2.2; i686; ; ) References: <1179647550.1253129638584.JavaMail.jira@brutus> In-Reply-To: <1179647550.1253129638584.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="Boundary-00=_WWUsKSezeWrd/zq" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200909162207.50836.paul.elschot@xs4all.nl> X-Virus-Scanned: by XS4ALL Virus Scanner X-Virus-Checked: Checked by ClamAV on apache.org --Boundary-00=_WWUsKSezeWrd/zq Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit I have not yet looked at the the patch, but after the comments at LUCENE-1911 I think isCacheable() could also return true for OpenBitSet, not only for SortedVIntList. Regards, Paul Elschot. On Wednesday 16 September 2009 21:33:58 Michael McCandless (JIRA) wrote: > > [ https://issues.apache.org/jira/browse/LUCENE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756194#action_12756194 ] > > Michael McCandless commented on LUCENE-1911: > -------------------------------------------- > > bq. we could add a DocIdSet.isCacheable() method > > +1 to this, and to keeping docIdSetToCache() for overriding. This is much cleaner than trying to check for every known DocIdSet impl. > > Thanks for fixing this Uwe! > > > When using QueryWrapperFilter with CachingWrapperFilter, QueryWrapperFilter returns a DocIdSet that creates a Scorer, which gets cached rather than a bit set > > ------------------------------------------------------------------------------------------------------------------------------------------------------------- > > > > Key: LUCENE-1911 > > URL: https://issues.apache.org/jira/browse/LUCENE-1911 > > Project: Lucene - Java > > Issue Type: Bug > > Reporter: Mark Miller > > Assignee: Uwe Schindler > > Fix For: 2.9 > > > > Attachments: LUCENE-1911.patch > > > > > > there is a large performance cost to this. > > The old impl for this type of thing, QueryFilter, recommends : > > @deprecated use a CachingWrapperFilter with QueryWrapperFilter > > The deprecated QueryFilter itself also suffers from the problem because its now implemented using a CachingWrapperFilter and QueryWrapperFilter. > > see http://search.lucidimagination.com/search/document/7f54715f14b8b7a/lucene_2_9_0rc4_slower_than_2_4_1 > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org > For additional commands, e-mail: java-dev-help@lucene.apache.org > > > --Boundary-00=_WWUsKSezeWrd/zq Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit I have not yet looked at the the patch, but after the comments at LUCENE-1911
I think isCacheable() could also return true for OpenBitSet, not only for SortedVIntList.


Regards,
Paul Elschot.



On Wednesday 16 September 2009 21:33:58 Michael McCandless (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/LUCENE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756194#action_12756194 ]
>
> Michael McCandless commented on LUCENE-1911:
> --------------------------------------------
>
> bq. we could add a DocIdSet.isCacheable() method
>
> +1 to this, and to keeping docIdSetToCache() for overriding. This is much cleaner than trying to check for every known DocIdSet impl.
>
> Thanks for fixing this Uwe!
>
> > When using QueryWrapperFilter with CachingWrapperFilter, QueryWrapperFilter returns a DocIdSet that creates a Scorer, which gets cached rather than a bit set
> > -------------------------------------------------------------------------------------------------------------------------------------------------------------
> >
> > Key: LUCENE-1911
> > URL: https://issues.apache.org/jira/browse/LUCENE-1911
> > Project: Lucene - Java
> > Issue Type: Bug
> > Reporter: Mark Miller
> > Assignee: Uwe Schindler
> > Fix For: 2.9
> >
> > Attachments: LUCENE-1911.patch
> >
> >
> > there is a large performance cost to this.
> > The old impl for this type of thing, QueryFilter, recommends :
> > @deprecated use a CachingWrapperFilter with QueryWrapperFilter
> > The deprecated QueryFilter itself also suffers from the problem because its now implemented using a CachingWrapperFilter and QueryWrapperFilter.
> > see http://search.lucidimagination.com/search/document/7f54715f14b8b7a/lucene_2_9_0rc4_slower_than_2_4_1
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>
>



--Boundary-00=_WWUsKSezeWrd/zq--