Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 555 invoked from network); 8 Sep 2009 21:19:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Sep 2009 21:19:22 -0000 Received: (qmail 39976 invoked by uid 500); 8 Sep 2009 21:19:21 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 39917 invoked by uid 500); 8 Sep 2009 21:19:21 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 39909 invoked by uid 99); 8 Sep 2009 21:19:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2009 21:19:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2009 21:19:18 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 71DAE234C044 for ; Tue, 8 Sep 2009 14:18:57 -0700 (PDT) Message-ID: <1891720703.1252444737454.JavaMail.jira@brutus> Date: Tue, 8 Sep 2009 14:18:57 -0700 (PDT) From: "Uwe Schindler (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-1903) Incorrect ShingleFilter behavior when outputUnigrams == false In-Reply-To: <1549628094.1252443357559.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752750#action_12752750 ] Uwe Schindler commented on LUCENE-1903: --------------------------------------- Did the test pass with 2.4.1? If yes, it's caused by the rewrite and could you please assign 2.9 as the affected version? I think Michael Busch did this TokenFilter, maybe he understands the shingle code. > Incorrect ShingleFilter behavior when outputUnigrams == false > ------------------------------------------------------------- > > Key: LUCENE-1903 > URL: https://issues.apache.org/jira/browse/LUCENE-1903 > Project: Lucene - Java > Issue Type: Bug > Components: contrib/analyzers > Reporter: Chris Harris > Attachments: LUCENE-1903_testcases.patch, TEST-org.apache.lucene.analysis.shingle.ShingleFilterTest.xml > > > ShingleFilter isn't working as expected when outputUnigrams == false. In particular, it is outputting unigrams at least some of the time when outputUnigrams==false. > I'll attach a patch to ShingleFilterTest.java that adds some test cases that demonstrate the problem. > I haven't checked this, but I hypothesize that the behavior for outputUnigrams == false got changed when the class was upgraded to the new TokenStream API? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org