lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1903) Incorrect ShingleFilter behavior when outputUnigrams == false
Date Tue, 08 Sep 2009 23:09:57 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752818#action_12752818
] 

Mark Miller commented on LUCENE-1903:
-------------------------------------

Okay - I'm not sure if I'll short for tonight or the morning yet (not so late here).

bq.  A CHANGES.txt entry is not needed in my opinion, as this is not a new feature or a bug
from 2.4.1.

This could prob be debated from a lot of angles - in the end, it appears pretty much up to
each committer what they do -

My rule of thumb has been - when it comes to me, be modest, skip where it makes sense. But
when it comes to someone else having reported
the issue - I always add a credit somehow. Outside contributions (in whatever form) deserves
credit for reporting things and suppling things (especially tests), and I think it encourages
that behavior to a small
degree. Proper credit to outside contributers is very important I think - thats why we put
someones name right next to ours, even when the user
may have just reported the issue and we did all the work - or even if two people did 98% of
the work and some guy drops a patch that changes
2%. Just my two cents on the subject though - take it for what its worth.

> Incorrect ShingleFilter behavior when outputUnigrams == false
> -------------------------------------------------------------
>
>                 Key: LUCENE-1903
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1903
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/analyzers
>    Affects Versions: 2.9
>            Reporter: Chris Harris
>             Fix For: 2.9
>
>         Attachments: LUCENE-1903.patch, LUCENE-1903_testcases.patch, LUCENE-1903_testcases_lucene2_4_1_version.patch,
TEST-org.apache.lucene.analysis.shingle.ShingleFilterTest.xml
>
>
> ShingleFilter isn't working as expected when outputUnigrams == false. In particular,
it is outputting unigrams at least some of the time when outputUnigrams==false.
> I'll attach a patch to ShingleFilterTest.java that adds some test cases that demonstrate
the problem.
> I haven't checked this, but I hypothesize that the behavior for outputUnigrams == false
got changed when the class was upgraded to the new TokenStream API?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message