lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-1896) Modify confusing javadoc for queryNorm
Date Thu, 10 Sep 2009 03:57:57 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mark Miller updated LUCENE-1896:
--------------------------------

    Attachment: queryNormAlternate.patch

This is a tricky change I think, but shoudnt it be more like this?

queryNorm takes the Weight rather than sumSquared - and then you can call sumSquared on the
weight or skip it, saving the few calcs, and isolating the work to the queryNorm impl.

The patch is unfinished though -

its an issue that queryNorm throws IOException - I don't think it should and i removed it
here, but thats not back compat. Pain in the butt.

also, I havn't given much thought to how we would migrate without breaking back compat - I
guess the introspection again ...

And perhaps we just leave it.

> Modify confusing javadoc for queryNorm
> --------------------------------------
>
>                 Key: LUCENE-1896
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1896
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Javadocs
>            Reporter: Jiri Kuhn
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1896.patch, queryNormAlternate.patch
>
>
> See http://markmail.org/message/arai6silfiktwcer
> The javadoc confuses me as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message