lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-1911) When using QueryWrapperFilter with CachingWrapperFilter, QueryWrapperFilter returns a DocIdSet that creates a Scorer, which gets cached rather than a bit set
Date Wed, 16 Sep 2009 20:53:57 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-1911:
----------------------------------

    Attachment: LUCENE-1911.patch

Here the implementation with isCacheable(). It also has an extra test, checking cacheable
on various filter with/without CachingWrapperFilter. The switch was removed from CachingWrapperFilter,
as the DocIdSet now says, if it should be cached or not.

I scanned through all DocIdSets and checked, if cacheable (in general: Do they do disk I/O
during iteration or are else very slow). I looked in core and contrib looking for "extends
DocIdSet" and "new DocIdSet()" anon inner classes.

If somebody knows another DocIdSet, that is cacheable, please tell!

All tests pass.

> When using QueryWrapperFilter with CachingWrapperFilter, QueryWrapperFilter returns a
DocIdSet that creates a Scorer, which gets cached rather than a bit set
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1911
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1911
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Uwe Schindler
>             Fix For: 2.9
>
>         Attachments: LUCENE-1911.patch, LUCENE-1911.patch
>
>
> there is a large performance cost to this.
> The old impl for this type of thing, QueryFilter, recommends :
> @deprecated use a CachingWrapperFilter with QueryWrapperFilter
> The deprecated QueryFilter itself also suffers from the problem because its now implemented
using a CachingWrapperFilter and QueryWrapperFilter.
> see http://search.lucidimagination.com/search/document/7f54715f14b8b7a/lucene_2_9_0rc4_slower_than_2_4_1

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message