lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1919) Analysis back compat break
Date Fri, 18 Sep 2009 02:59:58 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756924#action_12756924
] 

Robert Muir commented on LUCENE-1919:
-------------------------------------

bq. Still wonder if it's safe to get rid of that second clone()... the combinations are mind-bending.


its not safe to do this for the case of tokenstream that only supports next(reusableTS) but
not incrementToken.
otherwise, next() does not return a full copy, but a reference to the delegate, which will
be overwritten by future calls to next().
if you want to get rid of it, then you need to clone the delegate before deferring to next(Token).


> Analysis back compat break
> --------------------------
>
>                 Key: LUCENE-1919
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1919
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Yonik Seeley
>             Fix For: 2.9
>
>         Attachments: LUCENE-1919.patch, LUCENE-1919.patch, LUCENE-1919.patch
>
>
> Old and new style token streams don't mix well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message