lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Updated: (LUCENE-1903) Incorrect ShingleFilter behavior when outputUnigrams == false
Date Tue, 08 Sep 2009 22:26:57 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-1903:
----------------------------------

    Attachment: LUCENE-1903.patch

This patch seems to fix this issue. All tests pass.

This patch also removes an unnecessary isEmpty() check (because fillShingleBuffer already
returned false, if empty). I also replace remove(0) by removeFirst(), which is faster for
linked lists.

> Incorrect ShingleFilter behavior when outputUnigrams == false
> -------------------------------------------------------------
>
>                 Key: LUCENE-1903
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1903
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/analyzers
>    Affects Versions: 2.9
>            Reporter: Chris Harris
>             Fix For: 2.9
>
>         Attachments: LUCENE-1903.patch, LUCENE-1903_testcases.patch, LUCENE-1903_testcases_lucene2_4_1_version.patch,
TEST-org.apache.lucene.analysis.shingle.ShingleFilterTest.xml
>
>
> ShingleFilter isn't working as expected when outputUnigrams == false. In particular,
it is outputting unigrams at least some of the time when outputUnigrams==false.
> I'll attach a patch to ShingleFilterTest.java that adds some test cases that demonstrate
the problem.
> I haven't checked this, but I hypothesize that the behavior for outputUnigrams == false
got changed when the class was upgraded to the new TokenStream API?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message