lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1901) TermAttributeImpl.equals() does not check termLength
Date Tue, 08 Sep 2009 20:51:57 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752738#action_12752738
] 

Uwe Schindler commented on LUCENE-1901:
---------------------------------------

Thanks. I committed the patch. I also added the same test to Token.java, because it could
have the same problem.

At revision: 812690

> TermAttributeImpl.equals() does not check termLength
> ----------------------------------------------------
>
>                 Key: LUCENE-1901
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1901
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 2.9
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 2.9
>
>         Attachments: LUCENE-1901.addTest.patch, LUCENE-1901.patch
>
>
> If you look at the code from equals(), I think it misses this check :
> other.termLength==this.termLength
> This check must be before the comparison of the arrays.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message