Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 1415 invoked from network); 27 Aug 2009 18:37:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Aug 2009 18:37:49 -0000 Received: (qmail 93415 invoked by uid 500); 27 Aug 2009 18:37:48 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 93346 invoked by uid 500); 27 Aug 2009 18:37:48 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 93338 invoked by uid 99); 27 Aug 2009 18:37:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Aug 2009 18:37:48 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of rcmuir@gmail.com designates 209.85.217.216 as permitted sender) Received: from [209.85.217.216] (HELO mail-gx0-f216.google.com) (209.85.217.216) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Aug 2009 18:37:39 +0000 Received: by gxk12 with SMTP id 12so1720873gxk.4 for ; Thu, 27 Aug 2009 11:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=Bj48K0Mh86g40X+NCNEgpPukb1108wsChFxdiNw2YxM=; b=elJl6BEmgg3pI8xxcHCqwN/+q9cP4fWgvYj+mJJQT9F642FJCpOlOJPLgXZecfywu8 HotAEjUiBp7JJvtfZ6n1ytxosvUmTmaz/Ux4fNX1HYyLF3p7qHP27osnJpMdY+RrzJO7 kBkFO0X1uoiz9ldSpFx8KwJ+U8fCT7tA+o//k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=Z7G91I1pE9QYrD6jN0PA1Q3ROnce5a2WdME8iUeVvWGp3pPeLMY+/dDR8azYErrRUD avwC4V+7wLRDO2KbPk1i1WAghAS0MQadOE4VBY/J9DqMSYgHzxZWjMPIq2iis7yIi2Jb R21n4JVb/bG+cFq2TRswXWlz3eCRDo2wSxv70= MIME-Version: 1.0 Received: by 10.101.94.4 with SMTP id w4mr10084240anl.22.1251398238797; Thu, 27 Aug 2009 11:37:18 -0700 (PDT) In-Reply-To: <4A96D1E2.7070609@gmail.com> References: <20090827170553.8E16F2388903@eris.apache.org> <4A96D178.9080901@gmail.com> <4A96D1E2.7070609@gmail.com> Date: Thu, 27 Aug 2009 14:37:18 -0400 Message-ID: <8f0ad1f30908271137u3aed3307r434cd1ab835a6f0d@mail.gmail.com> Subject: Re: svn commit: r808530 - /lucene/java/trunk/src/test/org/apache/lucene/index/TestCheckIndex.java From: Robert Muir To: java-dev@lucene.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org i do not want to delay anything but if someone could provide opinion on javadocs-only patch for LUCENE-1817, i would appreciate it. On Thu, Aug 27, 2009 at 2:35 PM, Mark Miller wrote: > NM - didn't read the code - I see you ||'d it. I'm revving up to do the > RC soon - if anyone has any objections or anything they want to hold off > for - speak up. > > Mark Miller wrote: >> Should this go in the release todo? >> >> mikemccand@apache.org wrote: >> >>> Author: mikemccand >>> Date: Thu Aug 27 17:05:53 2009 >>> New Revision: 808530 >>> >>> URL: http://svn.apache.org/viewvc?rev=3D808530&view=3Drev >>> Log: >>> fix TestCheckIndex to accept either 2.9 or 2.9-dev as valid, from commo= n-build.xml >>> >>> Modified: >>> =C2=A0 =C2=A0 lucene/java/trunk/src/test/org/apache/lucene/index/TestCh= eckIndex.java >>> >>> Modified: lucene/java/trunk/src/test/org/apache/lucene/index/TestCheckI= ndex.java >>> URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/test/org/apache= /lucene/index/TestCheckIndex.java?rev=3D808530&r1=3D808529&r2=3D808530&view= =3Ddiff >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- lucene/java/trunk/src/test/org/apache/lucene/index/TestCheckIndex.j= ava (original) >>> +++ lucene/java/trunk/src/test/org/apache/lucene/index/TestCheckIndex.j= ava Thu Aug 27 17:05:53 2009 >>> @@ -93,7 +93,9 @@ >>> =C2=A0 =C2=A0public void testLuceneConstantVersion() throws IOException= { >>> =C2=A0 =C2=A0 =C2=A0// common-build.xml sets lucene.version >>> =C2=A0 =C2=A0 =C2=A0final String version =3D System.getProperty("lucene= .version"); >>> - =C2=A0 =C2=A0assertEquals(version, Constants.LUCENE_MAIN_VERSION+"-de= v"); >>> + =C2=A0 =C2=A0assertNotNull(version); >>> + =C2=A0 =C2=A0assertTrue(version.equals(Constants.LUCENE_MAIN_VERSION+= "-dev") || >>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 version.equals(Const= ants.LUCENE_MAIN_VERSION)); >>> =C2=A0 =C2=A0 =C2=A0assertTrue(Constants.LUCENE_VERSION.startsWith(vers= ion)); >>> =C2=A0 =C2=A0} >>> =C2=A0} >>> >>> >>> >>> >> >> >> > > > -- > - Mark > > http://www.lucidimagination.com > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org > For additional commands, e-mail: java-dev-help@lucene.apache.org > > --=20 Robert Muir rcmuir@gmail.com --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org