Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Received-SPF: pass (nike.apache.org: domain of rcmuir@gmail.com designates
 209.85.132.241 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=yEzSDvUrDNkNsMPkfJmiNTmHBu93jBR2blrcGCHAafVUM3I3dfVolxr8yJKxYxJxS5
         AsdG5R4RxZNRbXH5HgfxPybqzvSrRIGW8S62n3Bt3gwmHicEDNYfbXN+0mQvd4Q+Bbju
         NbHBatb6lSeX0EeaCqrhVwUsIBq2n0TZmmFBk=
MIME-Version: 1.0
In-Reply-To: <4A812BC7.7000408@gmail.com>
References: <c68e39170908100901m35f325fcm10fa5225efb0bac9@mail.gmail.com>
	 <345ECC25630C46B8B55AED45F8B2C691@VEGA>
	 <4266B483-E969-44B0-90EC-810132D5A4B2@apache.org>
	 <B1F0812104E0461AAA3C2B808C8C9028@VEGA>
	 <786fde50908101412y4f52ffdcp71e7482c10550082@mail.gmail.com>
	 <E60B885E-7AE4-4BC9-A3D9-2B0EDC2BCD7D@apache.org>
	 <4A809F06.3000508@gmail.com>
	 <E1070CAA-A46F-4C66-8A01-3A16784AB8D8@apache.org>
	 <4A80CE34.8030208@gmail.com> <4A812BC7.7000408@gmail.com>
Date: Tue, 11 Aug 2009 06:50:22 -0400
Message-ID: <8f0ad1f30908110350wf3385cfseb81bb59b27fc21@mail.gmail.com>
Subject: Re: who clears attributes?
From: Robert Muir <rcmuir@gmail.com>
To: java-dev@lucene.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On Tue, Aug 11, 2009 at 4:28 AM, Michael Busch<buschmic@gmail.com> wrote:
> There was a performance test in Solr that apparently ran much slower
> after upgrading to the new Lucene jar. This test is testing a rather
> uncommon scenario: very very short documents.

Actually, its more uncommon than that: its very very short documents,
without implementing reusableTokenStream()
this makes it basically a benchmark of ctor cost... doesn't really
benchmark the token api in my opinion.

we should do some better benchmarks, but in most cases things appear
to be the same to me.
it is only this case where you have very very short documents but
don't implement reuse things,
that there is any difference, and now it is minor.

-- 
Robert Muir
rcmuir@gmail.com

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org