Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <2066468606.1251070559266.JavaMail.jira@brutus>
Date: Sun, 23 Aug 2009 16:35:59 -0700 (PDT)
From: "Uwe Schindler (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Issue Comment Edited: (LUCENE-1843) Convert some tests to
 new TokenStream API, better support of cross-impl AttributeImpl.copyTo()
In-Reply-To: <975769172.1250944574821.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746694#action_12746694 ] 

Uwe Schindler edited comment on LUCENE-1843 at 8/23/09 4:35 PM:
----------------------------------------------------------------

Patch that makes all contrib/analyzer tests that work with TokenStreams subclasses of BaseTokenStreamTestCase. This superclass now has a lot of utility methods to check TokenStreams using arrays of strings/ints.

The patch also contains a better version of SingleTokenTokenStream, using the Token.copyTo() function and a Token/TokenWrapper instance as attribute implementation.

This patch may still include some unused imports, had no time to check this manually (I am the person, that codes with Notepad...)

      was (Author: thetaphi):
    Patch that makes all contrib/analyzer tests that work with TokenStreams subclasses of BaseTokenStreamTestCase. This superclass now has a lot of utility methods to check TokenStreams using arrays of strings/ints.

This patch may still include some unused imports, had no time to check this manually (I am the person, that codes with Notepad...)
  
> Convert some tests to new TokenStream API, better support of cross-impl AttributeImpl.copyTo()
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1843
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1843
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>    Affects Versions: 2.9
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 2.9
>
>         Attachments: LUCENE-1843.patch, LUCENE-1843.patch
>
>
> This patch converts some remaining tests to the new TokenStream API and non-deprecated classes.
> This patch also enhances AttributeImpl.copyTo() of Token and TokenWrapper to also support copying e.g. TermAttributeImpl into Token. The target impl must only support all interfaces but must not be of the same type. Token and TokenWrapper use optimized coping without casting to 6 interfaces where possible.
> Maybe the special tokenizers in contrib (shingle matrix and so on using tokens to cache may be enhanced by that). Also Yonik's request for optimized copying of states between incompatible AttributeSources may be enhanced by that (possibly a new issue).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org