Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <1834963243.1250023334852.JavaMail.jira@brutus>
Date: Tue, 11 Aug 2009 13:42:14 -0700 (PDT)
From: "Michael McCandless (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Commented: (LUCENE-1771) Using explain may double ram reqs
 for fieldcaches when using ValueSourceQuery/CustomScoreQuery or for
 ConstantScoreQuerys that use a caching Filter.
In-Reply-To: <335549170.1248986774944.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742051#action_12742051 ] 

Michael McCandless commented on LUCENE-1771:
--------------------------------------------

Maybe say "Weight#explain now takes the top-level searcher, sub-reader and sub-docID"?

Also there's a small typo (andd -> and).

{quote}
So one thing I don't like is

bq. The new method is used by IndexSearcher to mate Collector and Scorer orderness of doc IDs.
{quote}

How about "IndexSearcher uses this method to obtain a scorer matching the capabilities of the Collector wrt orderness of docIDs"?

bq.  Also, while the entry talks a lot about the orderedIds param, it doesn't really mention the topScorer param

How about simply removing the first sentence, ie, just jump straight into "if true..."?

> Using explain may double ram reqs for fieldcaches when using ValueSourceQuery/CustomScoreQuery or for ConstantScoreQuerys that use a caching Filter.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1771
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1771
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1771.bc-tests.patch, LUCENE-1771.patch, LUCENE-1771.patch, LUCENE-1771.patch, LUCENE-1771.patch, LUCENE-1771.patch, LUCENE-1771.patch, LUCENE-1771.patch, LUCENE-1771.patch, LUCENE-1771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org