Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 90966 invoked from network); 5 Aug 2009 03:20:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Aug 2009 03:20:33 -0000 Received: (qmail 11740 invoked by uid 500); 5 Aug 2009 03:20:39 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 11649 invoked by uid 500); 5 Aug 2009 03:20:39 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 11640 invoked by uid 99); 5 Aug 2009 03:20:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Aug 2009 03:20:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Aug 2009 03:20:36 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 19C0029A001F for ; Tue, 4 Aug 2009 20:20:15 -0700 (PDT) Message-ID: <1830377725.1249442415104.JavaMail.jira@brutus> Date: Tue, 4 Aug 2009 20:20:15 -0700 (PDT) From: "Koji Sekiguchi (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Issue Comment Edited: (LUCENE-1773) Add benchmark task for FastVectorHighlighter In-Reply-To: <81143171.1249149854847.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739323#action_12739323 ] Koji Sekiguchi edited comment on LUCENE-1773 at 8/4/09 8:20 PM: ---------------------------------------------------------------- bq. ReadTask.doHighlight is deprecated - but if you still use it, whats the point? It's not called and it doesnt help to have it anymore? Hmm, I don't understand... I marked ReadTask.doHighlight deprecated and never used it. I think BenchmarkHighlighter.doHighlight() was called in doLogic()? was (Author: koji): bq. ReadTask.doHighlight is deprecated - but if you still use it, whats the point? It's not called and it doesnt help to have it anymore? Hmm, I don't understand... I marked ReadTask.doHighlight and never used it. I think BenchmarkHighlighter.doHighlight() was called in doLogic()? > Add benchmark task for FastVectorHighlighter > -------------------------------------------- > > Key: LUCENE-1773 > URL: https://issues.apache.org/jira/browse/LUCENE-1773 > Project: Lucene - Java > Issue Type: New Feature > Components: contrib/benchmark > Affects Versions: 2.9 > Reporter: Koji Sekiguchi > Assignee: Michael McCandless > Priority: Trivial > Fix For: 2.9 > > Attachments: LUCENE-1773.patch, LUCENE-1773.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org