lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: Sorting cleanup and FieldCacheImpl.Entry confusion
Date Mon, 10 Aug 2009 18:38:39 GMT
On Mon, Aug 10, 2009 at 1:57 PM, Chris
Hostetter<hossman_lucene@fucit.org> wrote:
> : I don't know why Entry has "int type" and "String locale", either.  I
> : agree it'd be cleaner for FieldSortedHitQueue to store these on its
> : own, privately.
> :
> : Note that FieldSortedHitQueue is deprecated in favor of
> : FieldValueHitQueue, and that FieldValueHitQueue doesn't cache
> : comparators anymore.
>
> yeah ... but i'm hesitent to try and refactor that code at this point,
> especitally if FieldSortedHitQueue is going to be removed in 3.0.
>
> I'm thinking that for the time being, it's probably simpler to just
> comment those properties as being removable once FieldSortedHitQueue is
> removed, and leave them out of the CacheEntry (debugging/sanity) API,
> since there's no code path that will cause them to be set in
> FieldCacheImpl.
>
> is that cool with people?

Sounds good to me!

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message