lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1779) Remove unused "numSlotsFull" from FieldComparator.setNextReader
Date Tue, 04 Aug 2009 16:35:15 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739023#action_12739023
] 

Yonik Seeley commented on LUCENE-1779:
--------------------------------------

+1
Thanks Mike, much improved!

FieldComparator.sortType() is an interesting one too... I don't think it's currently used,
and I have a hard time seeing how it could be used (when custom sort fields are involved).

> Remove unused "numSlotsFull" from FieldComparator.setNextReader
> ---------------------------------------------------------------
>
>                 Key: LUCENE-1779
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1779
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1779.patch
>
>
> This param is a relic from older optimizations that we've since turned off, and it's
quite confusing.  I don't think we need it, and we haven't released the API yet so we're free
to remove it now.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message