lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Muir <rcm...@gmail.com>
Subject Re: svn commit: r808530 - /lucene/java/trunk/src/test/org/apache/lucene/index/TestCheckIndex.java
Date Thu, 27 Aug 2009 18:37:18 GMT
i do not want to delay anything but if someone could provide opinion
on javadocs-only patch for LUCENE-1817, i would appreciate it.

On Thu, Aug 27, 2009 at 2:35 PM, Mark Miller<markrmiller@gmail.com> wrote:
> NM - didn't read the code - I see you ||'d it. I'm revving up to do the
> RC soon - if anyone has any objections or anything they want to hold off
> for - speak up.
>
> Mark Miller wrote:
>> Should this go in the release todo?
>>
>> mikemccand@apache.org wrote:
>>
>>> Author: mikemccand
>>> Date: Thu Aug 27 17:05:53 2009
>>> New Revision: 808530
>>>
>>> URL: http://svn.apache.org/viewvc?rev=808530&view=rev
>>> Log:
>>> fix TestCheckIndex to accept either 2.9 or 2.9-dev as valid, from common-build.xml
>>>
>>> Modified:
>>>     lucene/java/trunk/src/test/org/apache/lucene/index/TestCheckIndex.java
>>>
>>> Modified: lucene/java/trunk/src/test/org/apache/lucene/index/TestCheckIndex.java
>>> URL: http://svn.apache.org/viewvc/lucene/java/trunk/src/test/org/apache/lucene/index/TestCheckIndex.java?rev=808530&r1=808529&r2=808530&view=diff
>>> ==============================================================================
>>> --- lucene/java/trunk/src/test/org/apache/lucene/index/TestCheckIndex.java (original)
>>> +++ lucene/java/trunk/src/test/org/apache/lucene/index/TestCheckIndex.java Thu
Aug 27 17:05:53 2009
>>> @@ -93,7 +93,9 @@
>>>    public void testLuceneConstantVersion() throws IOException {
>>>      // common-build.xml sets lucene.version
>>>      final String version = System.getProperty("lucene.version");
>>> -    assertEquals(version, Constants.LUCENE_MAIN_VERSION+"-dev");
>>> +    assertNotNull(version);
>>> +    assertTrue(version.equals(Constants.LUCENE_MAIN_VERSION+"-dev") ||
>>> +               version.equals(Constants.LUCENE_MAIN_VERSION));
>>>      assertTrue(Constants.LUCENE_VERSION.startsWith(version));
>>>    }
>>>  }
>>>
>>>
>>>
>>>
>>
>>
>>
>
>
> --
> - Mark
>
> http://www.lucidimagination.com
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>



-- 
Robert Muir
rcmuir@gmail.com

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message