lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector
Date Tue, 25 Aug 2009 03:27:59 GMT


Shai Erera commented on LUCENE-1849:

bq. I think we should simply do nothing

+1. So many use cases brought up in this issue, and so many "helper" classes. I just can't
help imagining the future of this "I want a non scoring collector, which accepts docs out
of order, and keeps its next reader ..." and we'll try very hard to create a helper class
which does that because now we cannot inherit from two 'abstract' Collectors, each achieving
part of it.

I also feel that when I'll upgrade all of HitCollectors to Collector, the decision on what
to do where will not be that difficult - it's pretty straightforward I think. At least it's
the same decision as "which collector should I subclass" ...

> Add OutOfOrderCollector and InOrderCollector subclasses of Collector
> --------------------------------------------------------------------
>                 Key: LUCENE-1849
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Wish
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Tim Smith
>            Priority: Minor
>             Fix For: 2.9
> I find myself always having to implement these methods, and i always return a constant
(depending on if the collector can handle out of order hits)
> would be nice for these two convenience abstract classes to exist that implemented acceptsDocsOutOfOrder()
as final and returned the appropriate value

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message