lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1791) Enhance QueryUtils and CheckHIts to wrap everything they check in MultiReader/MultiSearcher
Date Wed, 12 Aug 2009 22:12:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742608#action_12742608
] 

Mark Miller commented on LUCENE-1791:
-------------------------------------

Okay - so the first the original Parser issue:

The output looked odd - it showed multiple entries with the same type, field, and reader,
but null and DefaultParser.

When I quickly switched the code to use DefaultParser instead of null, those extra entries
went away, and it just showed the segmentreader and directory reader that were doubled up.
Thats what had me thinking that was involved. I'm not sure I understand why that was happening
now though.

Anyway, all of the issues appear to be because the test code was written expecting all of
the readers to be top level.

The tests, in certain cases, use a Reader to grab from a fieldcache - that reader has to be
the right subreader and not the top level reader -

the tests were just using getSequentialSubReaders - they need use gatherSubReaders instead
- because you introduced the multi level reader stuff. They should have used gatherSubReaders
from the start, but because it wasn't needed at the time (for the tests to pass), it didn't
even occur to me.

> Enhance QueryUtils and CheckHIts to wrap everything they check in MultiReader/MultiSearcher
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1791
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1791
>             Project: Lucene - Java
>          Issue Type: Test
>            Reporter: Hoss Man
>             Fix For: 2.9
>
>         Attachments: LUCENE-1791.patch, LUCENE-1791.patch
>
>
> methods in CheckHits & QueryUtils are in a good position to take any Searcher they
are given and not only test it, but also test MultiReader & MultiSearcher constructs built
around them

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message