lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luis Alves (JIRA)" <>
Subject [jira] Commented: (LUCENE-1782) Rename OriginalQueryParserHelper
Date Thu, 06 Aug 2009 00:31:14 GMT


Luis Alves commented on LUCENE-1782:

I also want to point to everyone, that we should push for developers 
that want to have more control over the QueryParser, the use of SyntaxParser, 
Processors, Builders interfaces.

The QueryParserHelper was supposed to be a basic class for basic usage.

Anything that required extra tweaking of the QP should be done directly by
calling the StandartSynxtaParser, StandartProcessorPipeline, StandartQueryTreeBuilder 
directly, or by creating new ones.

If we expect the user to combine Processors, Builders, or syntaxParser implementations in
the future,
we should avoid having name overlap in this initial design.

> Rename OriginalQueryParserHelper
> --------------------------------
>                 Key: LUCENE-1782
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: LUCENE-1782.patch
> We should rename the new QueryParser so it's clearer that it's
> Lucene's default QueryParser, going forward, and not just a temporary
> "bridge" to a future new QueryParser.
> How about we rename oal.queryParser.original -->
> oal.queryParser.standard (can't use "default": it's a Java keyword)?
> Then, leave the OriginalQueryParserHelper under that package, but
> simply rename it to QueryParser?
> This way if we create other sub-packages in the future, eg
> ComplexPhraseQueryParser, they too can have a QueryParser class under
> them, to make it clear that's the "top" class you use to parse
> queries.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message