lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] Commented: (LUCENE-1794) implement reusableTokenStream for all contrib analyzers
Date Mon, 10 Aug 2009 15:52:14 GMT


Shai Erera commented on LUCENE-1794:

I actually meant to pull the class SavedStreams up to Analyzer, and leave the rest of the
logic in each Analyzer impl (I don't think there can be a default impl for all). SavedStreams
have a Tokenizer and TokenFilter, which is what every reusable token stream needs.

As for PerFieldAnalyzerWrapper --> it will still have a reusableTS(field) version to call.
But when you call this method, you guarantee you reuse a TS for that field only.

But if IW needs to call this method for every field it parses, then it can only call reusableTokenStream(field),
and therefore I wonder how that optimization work ...

> implement reusableTokenStream for all contrib analyzers
> -------------------------------------------------------
>                 Key: LUCENE-1794
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: LUCENE-1794.patch, LUCENE-1794.patch
> most contrib analyzers do not have an impl for reusableTokenStream
> regardless of how expensive the back compat reflection is for indexing speed, I think
we should do this to mitigate any performance costs. hey, overall it might even be an improvement!
> the back compat code for non-final analyzers is already in place so this is easy money
in my opinion.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message