lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LUCENE-1771) Using explain may double ram reqs for fieldcaches when using ValueSourceQuery/CustomScoreQuery or for ConstantScoreQuerys that use a caching Filter.
Date Tue, 04 Aug 2009 21:32:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739182#action_12739182
] 

Mark Miller edited comment on LUCENE-1771 at 8/4/09 2:31 PM:
-------------------------------------------------------------

bq. which brings up another point... isn't a back-compat break too (since Weight is not a
QueryWeight)? IndexSearcher.Explanation explain(QueryWeight weight, int doc) throws IOException;

nice catch.

Hmmm - so scorer.explain(doc) would need to be deprecated cause it would need to take a Searcher
(too avoid putting it on QueryWeight) and the sub-reader - and again this would need to be
solved (like the current patch) a Query at a time. 

*edit*

And then there is somehow handling the back compat of that deprecation ...

      was (Author: markrmiller@gmail.com):
    bq. which brings up another point... isn't a back-compat break too (since Weight is not
a QueryWeight)? IndexSearcher.Explanation explain(QueryWeight weight, int doc) throws IOException;

nice catch.

Hmmm - so scorer.explain(doc) would need to be deprecated cause it would need to take a Searcher
(too avoid putting it on QueryWeight) and the sub-reader - and again this would need to be
solved (like the current patch) a Query at a time. 
  
> Using explain may double ram reqs for fieldcaches when using ValueSourceQuery/CustomScoreQuery
or for ConstantScoreQuerys that use a caching Filter.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1771
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1771
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1771.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message