lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Miller <markrmil...@gmail.com>
Subject Re: Fwd: [jira] Updated: (LUCENE-1869) when checking tvx/fdx size mismatch, also include whether the file exists
Date Fri, 28 Aug 2009 13:10:33 GMT
You won't see me complain.

- Mark

Michael McCandless wrote:
> Mark is it OK to commit this for 2.9?  It just improves debugging when
> users hit the existing fdx/tvx mismatch exception.
>
> Mike
>
> ---------- Forwarded message ----------
> From: Michael McCandless (JIRA) <jira@apache.org>
> Date: Fri, Aug 28, 2009 at 5:03 AM
> Subject: [jira] Updated: (LUCENE-1869) when checking tvx/fdx size
> mismatch, also include whether the file exists
> To: java-dev@lucene.apache.org
>
>
>
>     [ https://issues.apache.org/jira/browse/LUCENE-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Michael McCandless updated LUCENE-1869:
> ---------------------------------------
>
>    Attachment: LUCENE-1869.patch
>
> Attached patch.
>
> The patch is trivial (only changes the String message in the
> already-thrown RuntimeException when there is a mismatch detected in
> expected vs actual size of *.fdx or *.tvx).
>
>   
>> when checking tvx/fdx size mismatch, also include whether the file exists
>> -------------------------------------------------------------------------
>>
>>                 Key: LUCENE-1869
>>                 URL: https://issues.apache.org/jira/browse/LUCENE-1869
>>             Project: Lucene - Java
>>          Issue Type: Improvement
>>          Components: Index
>>            Reporter: Michael McCandless
>>            Assignee: Michael McCandless
>>            Priority: Trivial
>>             Fix For: 2.9
>>
>>         Attachments: LUCENE-1869.patch
>>
>>
>> IndexWriter checks, during flush and during merge, that the size of the index file
for stored fields (*.fdx) and term vectors (*.tvx) matches how many bytes it has just written.
>> This originally was added for LUCENE-1282, ie, as a safety to catch the nasty "off
by 1" JRE hotspot bug that would otherwise silently corrupt the index.
>> However, this check also seems to catch a different case, where the size of the file
is zero.   The most recent example is LUCENE-1521.  I'd like to improve the message in the
exception to include whether or not the file exists, to help understand why users are sometimes
hitting this exception.  My best theory at this point is something external is removing the
file out from under the IndexWriter.
>>     
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>   


-- 
- Mark

http://www.lucidimagination.com




---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message