lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Miller <markrmil...@gmail.com>
Subject Re: svn commit: r807809 - in /lucene/java/trunk: contrib/wikipedia/src/java/org/apache/lucene/wikipedia/analysis/ src/java/org/apache/lucene/analysis/ src/java/org/apache/lucene/analysis/standard/ src/java/org/apache/lucene/util/
Date Tue, 25 Aug 2009 22:59:35 GMT
Uwe Schindler wrote:
> No problem, it works. But it is strange why it works in some environments.
>   
Indeed - I don't know the answer to that one. I didn't get any warnings
or complaints from the javadoc tool, but the link did not work in
Chromium, eclipse's built in use of the Mozilla browser, or Firefox
until I made the change.
> Nevertheless: I get the following error when committing:
> Server sent unexpected return value (502 Proxy Error) in response to
> MKACTIVITY
> request for '/repos/asf/!svn/act/5e1f731c-f7e6-214d-bc2b-00b7b43831ad'
>
> Do you have this, too. I wanted to commit the in missing LUCENE-1826
> AttributeSource/AttributeFactory ctors for NumericTokenStream.
>   

I havn't seen that in any of my recent commit attempts ...
> -----
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>
>   
>> -----Original Message-----
>> From: Mark Miller [mailto:markrmiller@gmail.com]
>> Sent: Wednesday, August 26, 2009 12:31 AM
>> To: java-dev@lucene.apache.org
>> Subject: Re: svn commit: r807809 - in /lucene/java/trunk:
>> contrib/wikipedia/src/java/org/apache/lucene/wikipedia/analysis/
>> src/java/org/apache/lucene/analysis/
>> src/java/org/apache/lucene/analysis/standard/
>> src/java/org/apache/lucene/util/
>>
>> Okay - I've committed a change. I'm using sun java 5 on linux. The
>> resulting javadoc, for me has a broken link the way it was. Now the link
>> works. If it doesn't work for you, I will revert - but if it does - I
>> would prefer the link work for more people than less.
>>
>> - Mark
>>
>> Mark Miller wrote:
>>     
>>> It didn't work for me - and I'd prefer it works in all cases rather than
>>> one - its supposed to be a link that works.
>>>
>>> Uwe Schindler wrote:
>>>
>>>       
>>>>> I've already fixed it locally with some other javadoc.
>>>>>
>>>>> bq. So just leave {@link AttributeFactory}.
>>>>>
>>>>> Thats incorrect.
>>>>>
>>>>>
>>>>>           
>>>> But it worked. You can even reference the AttributeFactory without
>>>> AttributeSource from Java code inside e.g. StandardTokenizer. Maybe
>>>>         
>> that is
>>     
>>>> different in Java 1.6, but with 1.5 it works.
>>>>
>>>>
>>>>
>>>>         
>>>>> Uwe Schindler wrote:
>>>>>
>>>>>
>>>>>           
>>>>>> This produces tons of errors now:
>>>>>>
>>>>>>   [javadoc]
>>>>>> C:\Projects\lucene\trunk-
>>>>>>
>>>>>>
>>>>>>             
>>>>> full\src\java\org\apache\lucene\analysis\standard\S
>>>>>
>>>>>
>>>>>           
>>>>>> tandardTokenizer.java:147: warning - Tag @link: reference not found:
>>>>>> AttributeSource.AttributeFactory
>>>>>>
>>>>>> Before your change it worked without any warning. As AttributeSource
>>>>>>             
>> is
>>     
>>>>>>             
>>>>> a
>>>>>
>>>>>
>>>>>           
>>>>>> super of TokenStreams, all TokenStreams know AttributeSource as an
>>>>>>             
>> inner
>>     
>>>>>> class. This is why I left it without. If you want to do it that way,
>>>>>>             
>> you
>>     
>>>>>> have to import AttributeSource everywhere. So just leave {@link
>>>>>> AttributeFactory}.
>>>>>>
>>>>>> Uwe
>>>>>>
>>>>>> -----
>>>>>> Uwe Schindler
>>>>>> H.-H.-Meier-Allee 63, D-28213 Bremen
>>>>>> http://www.thetaphi.de
>>>>>> eMail: uwe@thetaphi.de
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>             
>>>>>>> -----Original Message-----
>>>>>>> From: markrmiller@apache.org [mailto:markrmiller@apache.org]
>>>>>>> Sent: Tuesday, August 25, 2009 11:27 PM
>>>>>>> To: java-commits@lucene.apache.org
>>>>>>> Subject: svn commit: r807809 - in /lucene/java/trunk:
>>>>>>> contrib/wikipedia/src/java/org/apache/lucene/wikipedia/analysis/
>>>>>>> src/java/org/apache/lucene/analysis/
>>>>>>> src/java/org/apache/lucene/analysis/standard/
>>>>>>> src/java/org/apache/lucene/util/
>>>>>>>
>>>>>>> Author: markrmiller
>>>>>>> Date: Tue Aug 25 21:26:35 2009
>>>>>>> New Revision: 807809
>>>>>>>
>>>>>>> URL: http://svn.apache.org/viewvc?rev=807809&view=rev
>>>>>>> Log:
>>>>>>> {@link AttributeFactory} should be {@link
>>>>>>> AttributeSource.AttributeFactory}
>>>>>>>
>>>>>>> Modified:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/contrib/wikipedia/src/java/org/apache/lucene/wikipedia/a
>>     
>>>>>           
>>>>>>> nalysis/WikipediaTokenizer.java
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/LetterTokenizer.java
>>     
>>>>>           
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/LowerCaseTokenizer.j
>>     
>>>>>           
>>>>>>> ava
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/WhitespaceTokenizer.
>>     
>>>>>           
>>>>>>> java
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/standard/StandardTok
>>     
>>>>>           
>>>>>>> enizer.java
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>> lucene/java/trunk/src/java/org/apache/lucene/util/AttributeSource.java
>>>>>
>>>>>
>>>>>           
>>>>>>> Modified:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/contrib/wikipedia/src/java/org/apache/lucene/wikipedia/a
>>     
>>>>>           
>>>>>>> nalysis/WikipediaTokenizer.java
>>>>>>> URL:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> http://svn.apache.org/viewvc/lucene/java/trunk/contrib/wikipedia/src/java/
>>     
>>>>>           
>> org/apache/lucene/wikipedia/analysis/WikipediaTokenizer.java?rev=807809&r1
>>     
>>>>>           
>>>>>>> =807808&r2=807809&view=diff
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> ==========================================================================
>>     
>>>>>           
>>>>>>> ====
>>>>>>> ---
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/contrib/wikipedia/src/java/org/apache/lucene/wikipedia/a
>>     
>>>>>           
>>>>>>> nalysis/WikipediaTokenizer.java (original)
>>>>>>> +++
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/contrib/wikipedia/src/java/org/apache/lucene/wikipedia/a
>>     
>>>>>           
>>>>>>> nalysis/WikipediaTokenizer.java Tue Aug 25 21:26:35 2009
>>>>>>> @@ -157,7 +157,7 @@
>>>>>>>
>>>>>>>    /**
>>>>>>>     * Createa a new instance of the {@link
>>>>>>> org.apache.lucene.wikipedia.analysis.WikipediaTokenizer}.  Attaches
>>>>>>>               
>> the
>>     
>>>>>>> -   * <conde>input</code> to a the newly created
JFlex scanner. Uses
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>> the
>>>>>
>>>>>
>>>>>           
>>>>>>> given {@link AttributeFactory}.
>>>>>>> +   * <conde>input</code> to a the newly created
JFlex scanner. Uses
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>> the
>>>>>
>>>>>
>>>>>           
>>>>>>> given {@link AttributeSource.AttributeFactory}.
>>>>>>>     *
>>>>>>>     * @param input The input
>>>>>>>     * @param tokenOutput One of {@link #TOKENS_ONLY}, {@link
>>>>>>> #UNTOKENIZED_ONLY}, {@link #BOTH}
>>>>>>>
>>>>>>> Modified:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/LetterTokenizer.java
>>     
>>>>>           
>>>>>>> URL:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/
>>     
>>>>>           
>> analysis/LetterTokenizer.java?rev=807809&r1=807808&r2=807809&view=diff
>>     
>>>>>>>
>>>>>>>               
>> ==========================================================================
>>     
>>>>>           
>>>>>>> ====
>>>>>>> ---
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/LetterTokenizer.java
>>     
>>>>>           
>>>>>>> (original)
>>>>>>> +++
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/LetterTokenizer.java
>>     
>>>>>           
>>>>>>> Tue Aug 25 21:26:35 2009
>>>>>>> @@ -40,7 +40,7 @@
>>>>>>>      super(source, in);
>>>>>>>    }
>>>>>>>
>>>>>>> -  /** Construct a new LetterTokenizer using a given {@link
>>>>>>> AttributeFactory}. */
>>>>>>> +  /** Construct a new LetterTokenizer using a given {@link
>>>>>>> AttributeSource.AttributeFactory}. */
>>>>>>>    public LetterTokenizer(AttributeFactory factory, Reader in)
{
>>>>>>>      super(factory, in);
>>>>>>>    }
>>>>>>>
>>>>>>> Modified:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/LowerCaseTokenizer.j
>>     
>>>>>           
>>>>>>> ava
>>>>>>> URL:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/
>>     
>>>>>           
>> analysis/LowerCaseTokenizer.java?rev=807809&r1=807808&r2=807809&view=diff
>>     
>>>>>           
>> ==========================================================================
>>     
>>>>>           
>>>>>>> ====
>>>>>>> ---
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/LowerCaseTokenizer.j
>>     
>>>>>           
>>>>>>> ava (original)
>>>>>>> +++
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/LowerCaseTokenizer.j
>>     
>>>>>           
>>>>>>> ava Tue Aug 25 21:26:35 2009
>>>>>>> @@ -43,7 +43,7 @@
>>>>>>>      super(source, in);
>>>>>>>    }
>>>>>>>
>>>>>>> -  /** Construct a new LowerCaseTokenizer using a given {@link
>>>>>>> AttributeFactory}. */
>>>>>>> +  /** Construct a new LowerCaseTokenizer using a given {@link
>>>>>>> AttributeSource.AttributeFactory}. */
>>>>>>>    public LowerCaseTokenizer(AttributeFactory factory, Reader
in) {
>>>>>>>      super(factory, in);
>>>>>>>    }
>>>>>>>
>>>>>>> Modified:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/WhitespaceTokenizer.
>>     
>>>>>           
>>>>>>> java
>>>>>>> URL:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/
>>     
>>>>>           
>> analysis/WhitespaceTokenizer.java?rev=807809&r1=807808&r2=807809&view=diff
>>     
>>>>>           
>> ==========================================================================
>>     
>>>>>           
>>>>>>> ====
>>>>>>> ---
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/WhitespaceTokenizer.
>>     
>>>>>           
>>>>>>> java (original)
>>>>>>> +++
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/WhitespaceTokenizer.
>>     
>>>>>           
>>>>>>> java Tue Aug 25 21:26:35 2009
>>>>>>> @@ -36,7 +36,7 @@
>>>>>>>      super(source, in);
>>>>>>>    }
>>>>>>>
>>>>>>> -  /** Construct a new WhitespaceTokenizer using a given {@link
>>>>>>> AttributeFactory}. */
>>>>>>> +  /** Construct a new WhitespaceTokenizer using a given {@link
>>>>>>> AttributeSource.AttributeFactory}. */
>>>>>>>    public WhitespaceTokenizer(AttributeFactory factory, Reader
in) {
>>>>>>>      super(factory, in);
>>>>>>>    }
>>>>>>>
>>>>>>> Modified:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/standard/StandardTok
>>     
>>>>>           
>>>>>>> enizer.java
>>>>>>> URL:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/
>>     
>>>>>           
>> analysis/standard/StandardTokenizer.java?rev=807809&r1=807808&r2=807809&vi
>>     
>>>>>           
>>>>>>> ew=diff
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> ==========================================================================
>>     
>>>>>           
>>>>>>> ====
>>>>>>> ---
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/standard/StandardTok
>>     
>>>>>           
>>>>>>> enizer.java (original)
>>>>>>> +++
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/analysis/standard/StandardTok
>>     
>>>>>           
>>>>>>> enizer.java Tue Aug 25 21:26:35 2009
>>>>>>> @@ -142,7 +142,7 @@
>>>>>>>    }
>>>>>>>
>>>>>>>    /**
>>>>>>> -   * Creates a new StandardTokenizer with a given {@link
>>>>>>> AttributeFactory}.
>>>>>>> +   * Creates a new StandardTokenizer with a given {@link
>>>>>>> AttributeSource.AttributeFactory}
>>>>>>>     */
>>>>>>>    public StandardTokenizer(AttributeFactory factory, Reader
input,
>>>>>>> boolean replaceInvalidAcronym) {
>>>>>>>      super(factory);
>>>>>>>
>>>>>>> Modified:
>>>>>>>
>>>>>>>               
>> lucene/java/trunk/src/java/org/apache/lucene/util/AttributeSource.java
>>     
>>>>>>> URL:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> http://svn.apache.org/viewvc/lucene/java/trunk/src/java/org/apache/lucene/
>>     
>>>>>           
>>>>>>> util/AttributeSource.java?rev=807809&r1=807808&r2=807809&view=diff
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>> ==========================================================================
>>     
>>>>>           
>>>>>>> ====
>>>>>>> ---
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>> lucene/java/trunk/src/java/org/apache/lucene/util/AttributeSource.java
>>>>>
>>>>>
>>>>>           
>>>>>>> (original)
>>>>>>> +++
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>> lucene/java/trunk/src/java/org/apache/lucene/util/AttributeSource.java
>>>>>
>>>>>
>>>>>           
>>>>>>> Tue Aug 25 21:26:35 2009
>>>>>>> @@ -93,7 +93,7 @@
>>>>>>>    private AttributeFactory factory;
>>>>>>>
>>>>>>>    /**
>>>>>>> -   * An AttributeSource using the default attribute factory
{@link
>>>>>>> AttributeFactory#DEFAULT_ATTRIBUTE_FACTORY}.
>>>>>>> +   * An AttributeSource using the default attribute factory
{@link
>>>>>>> AttributeSource.AttributeFactory#DEFAULT_ATTRIBUTE_FACTORY}.
>>>>>>>     */
>>>>>>>    public AttributeSource() {
>>>>>>>      this(AttributeFactory.DEFAULT_ATTRIBUTE_FACTORY);
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>               
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>             
>>>>> --
>>>>> - Mark
>>>>>
>>>>> http://www.lucidimagination.com
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>>
>>>>>
>>>>>           
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>>>
>>>>
>>>>
>>>>         
>>>
>>>       
>> --
>> - Mark
>>
>> http://www.lucidimagination.com
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-dev-help@lucene.apache.org
>>     
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-dev-help@lucene.apache.org
>
>   


-- 
- Mark

http://www.lucidimagination.com




---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message