lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Miller <markrmil...@gmail.com>
Subject TypeAttributeImpl
Date Thu, 20 Aug 2009 22:39:07 GMT
Getting into the nitpick stuff ;)

In TypeAttributeImpl:

  public void copyTo(AttributeImpl target) {
    TypeAttribute t = (TypeAttribute) target;
    t.setType(new String(type));
  }

The class uses type.equals and type.hashCode - is there any reason to
create a new String object here? Just use type ...

-- 
- Mark

http://www.lucidimagination.com




---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message