lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1748) getPayloadSpans on org.apache.lucene.search.spans.SpanQuery should be abstract
Date Tue, 11 Aug 2009 22:40:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742104#action_12742104
] 

Mark Miller commented on LUCENE-1748:
-------------------------------------

I'm tempted to make Spans abstract. We don't get these chances often. We managed to make Weight
abstract for 2.9, and I think similar logic applies here. We are already breaking the interface
- why not go abstract as well? Its a little more trouble, but we are already so far up the
creak, it could be worth it no? Its very hard to get rid of these interfaces in a normal situation,
and a better opportunity may not present itself.

> getPayloadSpans on org.apache.lucene.search.spans.SpanQuery should be abstract
> ------------------------------------------------------------------------------
>
>                 Key: LUCENE-1748
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1748
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Query/Scoring
>    Affects Versions: 2.4, 2.4.1
>         Environment: all
>            Reporter: Hugh Cayless
>            Assignee: Mark Miller
>             Fix For: 2.9
>
>         Attachments: LUCENE-1748.patch, LUCENE-1748.patch
>
>
> I just spent a long time tracking down a bug resulting from upgrading to Lucene 2.4.1
on a project that implements some SpanQuerys of its own and was written against 2.3.  Since
the project's SpanQuerys didn't implement getPayloadSpans, the call to that method went to
SpanQuery.getPayloadSpans which returned null and caused a NullPointerException in the Lucene
code, far away from the actual source of the problem.  
> It would be much better for this kind of thing to show up at compile time, I think.
> Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message