lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Elschot (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (LUCENE-1851) 'ant javacc' in root project should also properly create contrib/surround Java files
Date Tue, 25 Aug 2009 19:19:59 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747571#action_12747571
] 

Paul Elschot edited comment on LUCENE-1851 at 8/25/09 12:18 PM:
----------------------------------------------------------------

I've meanwhile switched to ubuntu, and I had to install javacc, which was easy.
Then I still had to apply the attached patch for javacc to common-build.xml, and put the following
line in ~/build.properties:
javacc.home=/usr/share/java

After that, these worked fine with Luis' patch applied from contrib/surround:
ant clean
ant javacc
ant test

Since the patch does not change the tests of the surround parser the change to the .jj file
still passed all the tests.

>From the top directory:
ant clean
ant javacc
ant test-contrib

also worked fine.

So, in all, this was a very nice excuse to reinstall javacc :)


      was (Author: paul.elschot@xs4all.nl):
    I've meanwhile switched to ubuntu, and I had to install javacc, which was easy.
Then I still had to apply the attached patch for javacc to common-build.xml, and put the following
line in ~/build.properties:
javacc.home=/usr/share/java

After that, these worked fine with the patch applied from contrib/surround:
ant clean
ant javacc
ant test

Since the patch does not change the tests of the surround parser the change to the .jj file
still passed all the tests.

>From the top directory:
ant clean
ant javacc
ant test-contrib

also worked fine.

So, in all, this was a very nice excuse to reinstall javacc :)

  
> 'ant javacc' in root project should also properly create contrib/surround Java files
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1851
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1851
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Paul Elschot
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: javacc20090825.patch, LUCENE-1851.patch
>
>
> For consistency after LUCENE-1829 which did the same for contrib/queryparser

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message