lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luis Alves (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1782) Rename OriginalQueryParserHelper
Date Thu, 06 Aug 2009 23:50:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740319#action_12740319
] 

Luis Alves commented on LUCENE-1782:
------------------------------------

I finally was able to apply the patch in eclipse.
But I had to use a different approach to correct the problem in eclipse. 

On command-line a execute:

{code}
cp -a src/test/org/apache/lucene/queryParser/original src/test/org/apache/lucene/queryParser/standard
cp -a src/java/org/apache/lucene/queryParser/original src/java/org/apache/lucene/queryParser/standard
cp src/java/org/apache/lucene/queryParser/standard/OriginalQueryParserHelper.java src/java/org/apache/lucene/queryParser/standard/StandardQueryParser.java
cp src/java/org/apache/lucene/queryParser/standard/nodes/OriginalBooleanQueryNode.java src/java/org/apache/lucene/queryParser/standard/nodes/StandardBooleanQueryNode.java
cp src/java/org/apache/lucene/queryParser/standard/parser/OriginalSyntaxParserConstants.java
src/java/org/apache/lucene/queryParser/standard/parser/StandardSyntaxParserConstants.java
cp src/java/org/apache/lucene/queryParser/standard/parser/OriginalSyntaxParser.java src/java/org/apache/lucene/queryParser/standard/parser/StandardSyntaxParser.java
cp src/java/org/apache/lucene/queryParser/standard/parser/OriginalSyntaxParserTokenManager.java
src/java/org/apache/lucene/queryParser/standard/parser/StandardSyntaxParserTokenManager.java
cp src/java/org/apache/lucene/queryParser/standard/parser/OriginalSyntaxParser.jj src/java/org/apache/lucene/queryParser/standard/parser/StandardSyntaxParser.jj
cp src/java/org/apache/lucene/queryParser/standard/processors/OriginalQueryNodeProcessorPipeline.java
src/java/org/apache/lucene/queryParser/standard/processors/StandardQueryNodeProcessorPipeline.java
cp src/java/org/apache/lucene/queryParser/standard/builders/OriginalQueryTreeBuilder.java
src/java/org/apache/lucene/queryParser/standard/builders/StandardQueryTreeBuilder.java
cp src/java/org/apache/lucene/queryParser/standard/builders/OriginalBooleanQueryNodeBuilder.java
src/java/org/apache/lucene/queryParser/standard/builders/StandardBooleanQueryNodeBuilder.java
cp src/java/org/apache/lucene/queryParser/standard/builders/OriginalQueryBuilder.java src/java/org/apache/lucene/queryParser/standard/builders/StandardQueryBuilder.java
cp src/java/org/apache/lucene/queryParser/standard/config/OriginalQueryConfigHandler.java
src/java/org/apache/lucene/queryParser/standard/config/StandardQueryConfigHandler.java
{code}

and applied the patch.

I did not see the readme.txt for the StandardSyntaxParser.jj, but everything else looks good.
:)


> Rename OriginalQueryParserHelper
> --------------------------------
>
>                 Key: LUCENE-1782
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1782
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1782.patch, LUCENE-1782.patch
>
>
> We should rename the new QueryParser so it's clearer that it's
> Lucene's default QueryParser, going forward, and not just a temporary
> "bridge" to a future new QueryParser.
> How about we rename oal.queryParser.original -->
> oal.queryParser.standard (can't use "default": it's a Java keyword)?
> Then, leave the OriginalQueryParserHelper under that package, but
> simply rename it to QueryParser?
> This way if we create other sub-packages in the future, eg
> ComplexPhraseQueryParser, they too can have a QueryParser class under
> them, to make it clear that's the "top" class you use to parse
> queries.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message