lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1791) Enhance QueryUtils and CheckHIts to wrap everything they check in MultiReader/MultiSearcher
Date Fri, 14 Aug 2009 03:16:21 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743061#action_12743061
] 

Mark Miller commented on LUCENE-1791:
-------------------------------------

{quote}sweet. i'll review the patch for real tomorow or sat, and maybe rip out the ItemizedFilter
and replace it with something more sensical (it's a bad example that people might stumble
upon, that seems even more confusing now, and i feel responsible since i'm the one that wrote
it for those explanation tests anyway)
{quote}

Cool - it is very confusing now, and not super clean really - its kind of a hack - I just
wasn't sure how else to handle it.

Essentially, every time it sees a reader, it assumes its a reader thats part of a sequence
of sub readers and adds maxDoc to a base to figure out what doc ids it should really set -
and then if it sees the top level reader, or the the first sub reader, it resets that base
- so it can start over if the set of sub readers need to come through again. It works for
these tests, but it makes no sense to do such a thing in the real world.

> Enhance QueryUtils and CheckHIts to wrap everything they check in MultiReader/MultiSearcher
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1791
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1791
>             Project: Lucene - Java
>          Issue Type: Test
>            Reporter: Hoss Man
>             Fix For: 2.9
>
>         Attachments: LUCENE-1791.patch, LUCENE-1791.patch, LUCENE-1791.patch, LUCENE-1791.patch,
LUCENE-1791.patch, LUCENE-1791.patch, LUCENE-1791.patch
>
>
> methods in CheckHits & QueryUtils are in a good position to take any Searcher they
are given and not only test it, but also test MultiReader & MultiSearcher constructs built
around them

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message