lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1782) Rename OriginalQueryParserHelper
Date Thu, 06 Aug 2009 19:31:15 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740219#action_12740219
] 

Michael McCandless commented on LUCENE-1782:
--------------------------------------------

I think if you run these commands, first, on a fresh checkout:
{code}
svn move src/test/org/apache/lucene/queryParser/original src/test/org/apache/lucene/queryParser/standard
svn move src/java/org/apache/lucene/queryParser/original src/java/org/apache/lucene/queryParser/standard
svn move src/java/org/apache/lucene/queryParser/standard/OriginalQueryParserHelper.java src/java/org/apache/lucene/queryParser/standard/StandardQueryParser.java
svn move src/java/org/apache/lucene/queryParser/standard/nodes/OriginalBooleanQueryNode.java
src/java/org/apache/lucene/queryParser/standard/nodes/StandardBooleanQueryNode.java
svn move src/java/org/apache/lucene/queryParser/standard/parser/OriginalSyntaxParserConstants.java
src/java/org/apache/lucene/queryParser/standard/parser/StandardSyntaxParserConstants.java
svn move src/java/org/apache/lucene/queryParser/standard/parser/OriginalSyntaxParser.java
src/java/org/apache/lucene/queryParser/standard/parser/StandardSyntaxParser.java
svn move src/java/org/apache/lucene/queryParser/standard/parser/OriginalSyntaxParserTokenManager.java
src/java/org/apache/lucene/queryParser/standard/parser/StandardSyntaxParserTokenManager.java
svn move src/java/org/apache/lucene/queryParser/standard/parser/OriginalSyntaxParser.jj src/java/org/apache/lucene/queryParser/standard/parser/StandardSyntaxParser.jj
svn move src/java/org/apache/lucene/queryParser/standard/processors/OriginalQueryNodeProcessorPipeline.java
src/java/org/apache/lucene/queryParser/standard/processors/StandardQueryNodeProcessorPipeline.java
svn move src/java/org/apache/lucene/queryParser/standard/builders/OriginalQueryTreeBuilder.java
src/java/org/apache/lucene/queryParser/standard/builders/StandardQueryTreeBuilder.java
svn move src/java/org/apache/lucene/queryParser/standard/builders/OriginalBooleanQueryNodeBuilder.java
src/java/org/apache/lucene/queryParser/standard/builders/StandardBooleanQueryNodeBuilder.java
svn move src/java/org/apache/lucene/queryParser/standard/builders/OriginalQueryBuilder.java
src/java/org/apache/lucene/queryParser/standard/builders/StandardQueryBuilder.java
svn move src/java/org/apache/lucene/queryParser/standard/config/OriginalQueryConfigHandler.java
src/java/org/apache/lucene/queryParser/standard/config/StandardQueryConfigHandler.java
{code}
Then apply the patch, it should work?

This happens because "svn diff" doesn't capture all required details (ie that things were
moved around), and, the "svn patch" (that'd be able to correctly apply what had been created
with "svn diff") isn't yet released.

> Rename OriginalQueryParserHelper
> --------------------------------
>
>                 Key: LUCENE-1782
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1782
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1782.patch, LUCENE-1782.patch
>
>
> We should rename the new QueryParser so it's clearer that it's
> Lucene's default QueryParser, going forward, and not just a temporary
> "bridge" to a future new QueryParser.
> How about we rename oal.queryParser.original -->
> oal.queryParser.standard (can't use "default": it's a Java keyword)?
> Then, leave the OriginalQueryParserHelper under that package, but
> simply rename it to QueryParser?
> This way if we create other sub-packages in the future, eg
> ComplexPhraseQueryParser, they too can have a QueryParser class under
> them, to make it clear that's the "top" class you use to parse
> queries.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message