lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <>
Subject [jira] Commented: (LUCENE-1817) it is impossible to use a custom dictionary for SmartChineseAnalyzer
Date Thu, 27 Aug 2009 18:55:59 GMT


Mark Miller commented on LUCENE-1817:

I vote commit it now so it makes the RC - I can appreciate wanting to have consensus here
- but silence is consensus in Lucene dev, - and twos often a crowd
By the powers vested in me as the RM (which are, essentially, none) I say pop this baby in.
People have a week to complain and force us to take it out. I think this one is fairly clear
territory though.
Lets put the first RC out with everything we know of taken care of. These are extraordinary

> it is impossible to use a custom dictionary for SmartChineseAnalyzer
> --------------------------------------------------------------------
>                 Key: LUCENE-1817
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 2.9
>         Attachments:, LUCENE-1817-mark-cn-experimental.patch, LUCENE-1817.patch,
> it is not possible to use a custom dictionary, even though there is a lot of code and
javadocs to allow this.
> This is because the custom dictionary is only loaded if it cannot load the built-in one
(which is of course, in the jar file and should load)
> {code}
> public synchronized static WordDictionary getInstance() {
>     if (singleInstance == null) {
>       singleInstance = new WordDictionary(); // load from jar file
>       try {
>         singleInstance.load();
>       } catch (IOException e) { // loading from jar file must fail before it checks the
AnalyzerProfile (where this can be configured)
>         String wordDictRoot = AnalyzerProfile.ANALYSIS_DATA_DIR;
>         singleInstance.load(wordDictRoot);
>       } catch (ClassNotFoundException e) {
>         throw new RuntimeException(e);
>       }
>     }
>     return singleInstance;
>   }
> {code}
> I think we should either correct this, document this, or disable custom dictionary support...

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message