lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Created: (LUCENE-1805) CloseableThreadLocal should allow null Objects
Date Thu, 13 Aug 2009 13:00:16 GMT
CloseableThreadLocal should allow null Objects
----------------------------------------------

                 Key: LUCENE-1805
                 URL: https://issues.apache.org/jira/browse/LUCENE-1805
             Project: Lucene - Java
          Issue Type: Bug
          Components: contrib/analyzers
    Affects Versions: 2.4.1
            Reporter: Shai Erera
             Fix For: 2.9


CloseableThreadLocal does not allow null Objects in its get() method, but does nothing to
prevent them in set(Object). The comment in get() before assert v != null is irrelevant -
the application might have passed null.

Null is an important value for Analyzers. Since tokenStreams (a ThreadLocal private member
in Analyzer) is not accessible by extending classes, the only way for an Analyzer to reset
the tokenStreams is by calling setPreviousTokenStream(null).

I will post a patch w/ a test

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message