lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1791) Enhance QueryUtils and CheckHIts to wrap everything they check in MultiReader/MultiSearcher
Date Wed, 12 Aug 2009 22:06:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742603#action_12742603
] 

Hoss Man commented on LUCENE-1791:
----------------------------------

{quote}
Well that explains half the output anyway - even if thats fixed there is still a fail. Its
because the tests doesn't expand fully into the subreaders - just needed the top level before
- with this test, we need to recursively grab them.
{quote}
You lost me there... are you saying the _tests_ needs to be changed? ... why?  

For this patch to trigger an error in an existing test, that test must either be using CheckHits
or QueryUtils to execute a query against a seracher and validate the results are ok ... why
would the test be responsible for any subreader expansion in this case?

> Enhance QueryUtils and CheckHIts to wrap everything they check in MultiReader/MultiSearcher
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1791
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1791
>             Project: Lucene - Java
>          Issue Type: Test
>            Reporter: Hoss Man
>             Fix For: 2.9
>
>         Attachments: LUCENE-1791.patch, LUCENE-1791.patch
>
>
> methods in CheckHits & QueryUtils are in a good position to take any Searcher they
are given and not only test it, but also test MultiReader & MultiSearcher constructs built
around them

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message