lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1817) it is impossible to use a custom dictionary for SmartChineseAnalyzer
Date Thu, 27 Aug 2009 18:41:59 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748497#action_12748497
] 

Mark Miller commented on LUCENE-1817:
-------------------------------------

I agree Robert - given your concerns, lots drop custom support for now (even if just at the
javadoc lvl if you can't do custom anyway without rebuilding the jar).

+1

> it is impossible to use a custom dictionary for SmartChineseAnalyzer
> --------------------------------------------------------------------
>
>                 Key: LUCENE-1817
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1817
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Priority: Minor
>         Attachments: dataFiles.zip, LUCENE-1817-mark-cn-experimental.patch, LUCENE-1817.patch,
LUCENE-1817.patch
>
>
> it is not possible to use a custom dictionary, even though there is a lot of code and
javadocs to allow this.
> This is because the custom dictionary is only loaded if it cannot load the built-in one
(which is of course, in the jar file and should load)
> {code}
> public synchronized static WordDictionary getInstance() {
>     if (singleInstance == null) {
>       singleInstance = new WordDictionary(); // load from jar file
>       try {
>         singleInstance.load();
>       } catch (IOException e) { // loading from jar file must fail before it checks the
AnalyzerProfile (where this can be configured)
>         String wordDictRoot = AnalyzerProfile.ANALYSIS_DATA_DIR;
>         singleInstance.load(wordDictRoot);
>       } catch (ClassNotFoundException e) {
>         throw new RuntimeException(e);
>       }
>     }
>     return singleInstance;
>   }
> {code}
> I think we should either correct this, document this, or disable custom dictionary support...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message