lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1837) Remove Searcher from explain and idf/maxDoc info from explain
Date Sun, 23 Aug 2009 15:50:59 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746622#action_12746622
] 

Michael McCandless commented on LUCENE-1837:
--------------------------------------------

bq. It won't revert the whole issue.

OK got it.

bq. Because TermWeight tried to take index level stats from the reader, we passed that searcher
(to make the TermWeight explain behavior like it was when we passed top level reader) - its
the only place its used currently.

PhraseQuery also prints the [top-level] docFreq for each term in the phrase.

bq. You cannot count on having access to the entire index through a Searcher - else we break
MultiSearcher and remote use.

I agree, so our fix in LUCENE-1771 doesn't work w/ MultiSearcher.  So we definitely need to
do something here...

The thing is, it's useful for TermQuery's explain to print out the docFreq/maxDoc, right?
 (This was the original motivation of LUCENE-1066).  But, it has to be the top-level numbers,
not the single-segment numbers.

Really the Weight should gather & hold all top-level stats it needs on construction? 
(The MultiSearcher is passed on Weight construction).

> Remove Searcher from explain and idf/maxDoc info from explain
> -------------------------------------------------------------
>
>                 Key: LUCENE-1837
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1837
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 2.9
>
>
> these changes (starting with the TermWeight idf/maxDoc info) were illegal IMO - I think
they need to be rolled back/out.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message