lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1784) Make BooleanWeight and DisjunctionMaxWeight protected
Date Sat, 08 Aug 2009 09:52:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740865#action_12740865
] 

Michael McCandless commented on LUCENE-1784:
--------------------------------------------

I'm a little nervous in general about opening up the Weight impls for Lucene's core Queries,
simply because in 2.9 (very much fresh on our minds right now) there have been very sizable
changes to how Weight works in general, and how certain queries (esp. BooleanQuery) create
scorers.  Opening up these classes further makes carrying out our back-compat policy even
more challenging, and they are already amazingly challenging.  In particular, the back-compat
implications of external subclasses to Lucene's core classes are the trickiest to get right.

> Make BooleanWeight and DisjunctionMaxWeight protected
> -----------------------------------------------------
>
>                 Key: LUCENE-1784
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1784
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 2.4
>            Reporter: Tim Smith
>            Priority: Minor
>         Attachments: LUCENE-1784.patch
>
>
> Currently, BooleanWeight is private, yet it has 2 protected members (similarity, weights)
which are unaccessible from custom code
> i have some use cases where it would be very useful to crawl a BooleanWeight to get at
the sub Weight objects
> however, since BooleanWeight is private, i have no way of doing this
> If BooleanWeight is protected, then i can subclass BooleanQuery to hook in and wrap BooleanWeight
with a subclass to facilitate this walking of the Weight objects
> Would also want DisjunctionMaxWeight to be protected, along with its "weights" member
> Would be even better if these Weights were made public with accessors to their sub "weights"
objects (then no subclassing would be necessary on my part)
> this should be really trivial and would be great if it can get into 2.9
> more generally, it would be nice if all Weight classes were public with nice accessors
to relevant "sub weights"/etc so custom code can get its hooks in where and when desired

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message