lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1749) FieldCache introspection API
Date Mon, 10 Aug 2009 18:39:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741479#action_12741479
] 

Hoss Man commented on LUCENE-1749:
----------------------------------

bq. Maybe we should simply print a warning, eg to System.err, on detecting that 2X RAM usage
has occurred, pointing people to the sanity checker? We could eg do it once only so we don't
spam the stderr logs

I'm not really comfortable dumping anything to System.err without user requesting it ... but
this is a really interesting idea.  (I suppose we could add an infoStream type idea to FieldCache
to expose this)

FieldCacheImpl.Cache.get could use the FieldCacheSanityChecker to inspect itself immediately
after calling createValue, and could even test if any of the Insanity instances returned are
related to the current call (by comparing the CacheEntry with the Entry it's using) ... it
could even log a useful stack trace since the sanity check would be happening in the same
call stack as at least one of the CacheEntries in the Insanity object.

I've opened LUCENE-1798 to track implmenting somehting like this once the FieldCacheSanityChecker
gets committed.

> FieldCache introspection API
> ----------------------------
>
>                 Key: LUCENE-1749
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1749
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Hoss Man
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: fieldcache-introspection.patch, LUCENE-1749-hossfork.patch, LUCENE-1749.patch,
LUCENE-1749.patch, LUCENE-1749.patch, LUCENE-1749.patch, LUCENE-1749.patch, LUCENE-1749.patch,
LUCENE-1749.patch, LUCENE-1749.patch, LUCENE-1749.patch, LUCENE-1749.patch, LUCENE-1749.patch,
LUCENE-1749.patch, LUCENE-1749.patch
>
>
> FieldCache should expose an Expert level API for runtime introspection of the FieldCache
to provide info about what is in the FieldCache at any given moment.  We should also provide
utility methods for sanity checking that the FieldCache doesn't contain anything "odd"...
>    * entries for the same reader/field with different types/parsers
>    * entries for the same field/type/parser in a reader and it's subreader(s)
>    * etc...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message