lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector
Date Tue, 25 Aug 2009 21:55:59 GMT


Michael McCandless commented on LUCENE-1849:

Good catch!  It should not be doing that.  It should be passing "true" down since it will
use advance.

But it doesn't result in a bug, because 1) its Weight.scoresDocsOutOfOrder returns false,
which causes IndexSearcher's sort by relevance or field methods to pick an in-order collector
which then causes IndexSearcher to pass "true" for scoreDocsInOrder, and 2) it's passing down
"false" for topScorer, which causes BooleanQuery to not return an out-of-order scorer.

I'll commit a fix plus a test shortly.

> Add OutOfOrderCollector and InOrderCollector subclasses of Collector
> --------------------------------------------------------------------
>                 Key: LUCENE-1849
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Wish
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Tim Smith
>            Priority: Minor
>             Fix For: 2.9
> I find myself always having to implement these methods, and i always return a constant
(depending on if the collector can handle out of order hits)
> would be nice for these two convenience abstract classes to exist that implemented acceptsDocsOutOfOrder()
as final and returned the appropriate value

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message