lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] Commented: (LUCENE-1791) Enhance QueryUtils and CheckHIts to wrap everything they check in MultiReader/MultiSearcher
Date Fri, 14 Aug 2009 00:13:14 GMT


Hoss Man commented on LUCENE-1791:

bq. Okay, I've got all tests passing.

Sweet! ... Even the random boolean query test? (i see changes to ReqExclScorer in your patch,
but i don't relaly see how that could solve the problem)

bq. I rigged up a smarted ItemizedFilter that works for these tests.

I'm clearly missing something ... why does ItemizedFilter need to change?  I know it's an
abomination and you would never want to use something like that in real code, but in this
test the docIds passed to it on construction shouldn't change -- even when we wrap the reader/searcher
in other searchers, i specificly only put empty indexes (with no deletions) in front of the
original index when bulding the multireader/searcher so the docIds will be the same.  why
doesn't the existing implementation work?

bq. Would it make sense to randomized reader / searcher indexes

Simon: randomized wrapping would be nice, but i didn't try to do that for two reasons:
   * the utility has no way to get the seed from LuceneTestCase, and i didn't want to introduce
randomness unless it was predictable randomness that could be logged.
   * i needed to be sure we didn't add an index with deletions prior to the original index
(but based on Mark's comments, it looks like that's not really an issue since we have to deal
with it anyway)

> Enhance QueryUtils and CheckHIts to wrap everything they check in MultiReader/MultiSearcher
> -------------------------------------------------------------------------------------------
>                 Key: LUCENE-1791
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Test
>            Reporter: Hoss Man
>             Fix For: 2.9
>         Attachments: LUCENE-1791.patch, LUCENE-1791.patch, LUCENE-1791.patch, LUCENE-1791.patch,
LUCENE-1791.patch, LUCENE-1791.patch
> methods in CheckHits & QueryUtils are in a good position to take any Searcher they
are given and not only test it, but also test MultiReader & MultiSearcher constructs built
around them

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message