lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Smith (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1849) Add OutOfOrderCollector and InOrderCollector subclasses of Collector
Date Mon, 24 Aug 2009 15:29:58 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746920#action_12746920
] 

Tim Smith commented on LUCENE-1849:
-----------------------------------

People tend to always reformat single line functions like that to use at lest 2 more lines
(i think checkstyle/eclipse formatting will often screw up my compact code if someone else
ever touches it))
also, you need the extra line for javadoc, so thats always 5 lines :(

I can always add these to classes to my class hierarchy (and i probably will if it doesn't
get added to lucene's search package)
but i think these are in general useful to anyone implementing collectors

a typical person porting to 2.9 can switch their HitCollector to subclass InOrderCollector
instead (in order to keep getting docs in order like lucene 2.4)
This then means they don't need to even think about acceptDocsOutOfOrder() semantics unless
they really want to
Also one less method to implement incorrectly for us application developers :)

> Add OutOfOrderCollector and InOrderCollector subclasses of Collector
> --------------------------------------------------------------------
>
>                 Key: LUCENE-1849
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1849
>             Project: Lucene - Java
>          Issue Type: Wish
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Tim Smith
>            Priority: Minor
>             Fix For: 2.9
>
>
> I find myself always having to implement these methods, and i always return a constant
(depending on if the collector can handle out of order hits)
> would be nice for these two convenience abstract classes to exist that implemented acceptsDocsOutOfOrder()
as final and returned the appropriate value

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message