lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] Commented: (LUCENE-1847) PhraseQuery/TermQuery use IndexReader specific stats in their explains
Date Mon, 24 Aug 2009 15:24:59 GMT


Michael McCandless commented on LUCENE-1847:

Patch looks good.  Can we name it IDFExplain instead of IdfExplain?  Nit-picky I know, but
I try to do all caps when the thing is already an acronym.

Shouldn't we deprecate Similarity's idf methods that return float?

You may want to defer calling IdfExplain.explain() until the Weight's explain is invoked?
 And, then, store the IdfExplain instance in the Weight, and then IdfExplain must implement
Serializable, and maybe add a Javadoc stating that Weight instances may hold onto your IdfExplain
so be careful about holding references to big/unserializable things if you need to serialize.

On back-compat... we could check (using reflection) if the subclass has overridden it, and
in that case forward to the subclass's method, with some canned explanation eg "inexplicable"

> PhraseQuery/TermQuery use IndexReader specific stats in their explains
> ----------------------------------------------------------------------
>                 Key: LUCENE-1847
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: LUCENE-1847.patch
> PhraseQuery uses IndexReader in explainfor top level stats - as mentioned by Mike McCandless
in LUCENE-1837.
> TermQuery uses IndexReader in explain for top level stats
> Always been a bug with MultiSearcher, but per segment search makes it worse.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message