lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1782) Rename OriginalQueryParserHelper
Date Wed, 05 Aug 2009 18:52:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739671#action_12739671
] 

Michael McCandless commented on LUCENE-1782:
--------------------------------------------

bq. Give it a try and let me know if it worked.

Looks like we also make mods to it to accept MessageImpl:

{code}
    [javac] Compiling 133 source files to /lucene/tmp.1782/build/contrib/queryparser/classes/java
    [javac] /lucene/tmp.1782/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/SyntaxParser.java:465:
cannot find symbol
    [javac] symbol  : constructor ParseException(org.apache.lucene.messages.MessageImpl)
    [javac] location: class org.apache.lucene.queryParser.standard.parser.ParseException
    [javac]            {if (true) throw new ParseException(new MessageImpl(QueryParserMessages.INVALID_SYNTAX_FUZZY_LIMITS));}
    [javac]                             ^
    [javac] /lucene/tmp.1782/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/ParseException.java:34:
cannot find symbol
    [javac] symbol  : constructor QueryNodeParseException(java.lang.String)
    [javac] location: class org.apache.lucene.queryParser.core.QueryNodeParseException
    [javac]     super("");
    [javac]     ^
    [javac] /lucene/tmp.1782/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/ParseException.java:52:
cannot find symbol
    [javac] symbol  : constructor QueryNodeParseException()
    [javac] location: class org.apache.lucene.queryParser.core.QueryNodeParseException
    [javac]     super();
    [javac]     ^
    [javac] /lucene/tmp.1782/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/ParseException.java:58:
cannot find symbol
    [javac] symbol  : constructor QueryNodeParseException(java.lang.String)
    [javac] location: class org.apache.lucene.queryParser.core.QueryNodeParseException
    [javac]     super(message);
    [javac]     ^
    [javac] /lucene/tmp.1782/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/EscapeQuerySyntaxImpl.java:270:
cannot find symbol
    [javac] symbol  : constructor ParseException(org.apache.lucene.messages.MessageImpl)
    [javac] location: class org.apache.lucene.queryParser.standard.parser.ParseException
    [javac]       throw new ParseException(new MessageImpl(
    [javac]             ^
    [javac] /lucene/tmp.1782/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/EscapeQuerySyntaxImpl.java:275:
cannot find symbol
    [javac] symbol  : constructor ParseException(org.apache.lucene.messages.MessageImpl)
    [javac] location: class org.apache.lucene.queryParser.standard.parser.ParseException
    [javac]       throw new ParseException(new MessageImpl(
    [javac]             ^
    [javac] /lucene/tmp.1782/contrib/queryparser/src/java/org/apache/lucene/queryParser/standard/parser/EscapeQuerySyntaxImpl.java:291:
cannot find symbol
    [javac] symbol  : constructor ParseException(org.apache.lucene.messages.MessageImpl)
    [javac] location: class org.apache.lucene.queryParser.standard.parser.ParseException
    [javac]       throw new ParseException(new MessageImpl(
    [javac]             ^
{code}

> Rename OriginalQueryParserHelper
> --------------------------------
>
>                 Key: LUCENE-1782
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1782
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 2.9
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>
> We should rename the new QueryParser so it's clearer that it's
> Lucene's default QueryParser, going forward, and not just a temporary
> "bridge" to a future new QueryParser.
> How about we rename oal.queryParser.original -->
> oal.queryParser.standard (can't use "default": it's a Java keyword)?
> Then, leave the OriginalQueryParserHelper under that package, but
> simply rename it to QueryParser?
> This way if we create other sub-packages in the future, eg
> ComplexPhraseQueryParser, they too can have a QueryParser class under
> them, to make it clear that's the "top" class you use to parse
> queries.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message