lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "DM Smith (JIRA)" <>
Subject [jira] Commented: (LUCENE-1794) implement reusableTokenStream for all contrib analyzers
Date Tue, 11 Aug 2009 12:34:15 GMT


DM Smith commented on LUCENE-1794:

If CachingTokenFilter.reset() means rewind, then how does one reset it?

Without that, it is not reusable.

When I did the prior token/filter changes, IIRC, some were not reusable. Maybe reset needs
to be documented that for reuse, the common case, it means reset (or no-op) and otherwise
means rewind. And then document which classes are not reusable.

Or should these single use classes be made reusable? This would argue for a rewind() method.
IMHO it is a bug that reset does not follow the contract.  

> implement reusableTokenStream for all contrib analyzers
> -------------------------------------------------------
>                 Key: LUCENE-1794
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 2.9
>         Attachments: LUCENE-1794.patch, LUCENE-1794.patch, LUCENE-1794.patch
> most contrib analyzers do not have an impl for reusableTokenStream
> regardless of how expensive the back compat reflection is for indexing speed, I think
we should do this to mitigate any performance costs. hey, overall it might even be an improvement!
> the back compat code for non-final analyzers is already in place so this is easy money
in my opinion.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message