Return-Path: 
 <java-dev-return-36735-apmail-lucene-java-dev-archive=lucene.apache.org@lucene.apache.org>
Delivered-To: apmail-lucene-java-dev-archive@www.apache.org
Received: (qmail 6309 invoked from network); 30 Jul 2009 03:29:14 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 30 Jul 2009 03:29:14 -0000
Received: (qmail 51898 invoked by uid 500); 30 Jul 2009 03:29:14 -0000
Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org
Received: (qmail 51738 invoked by uid 500); 30 Jul 2009 03:29:13 -0000
Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:java-dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:java-dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:java-dev@lucene.apache.org>
List-Id: <java-dev.lucene.apache.org>
Reply-To: java-dev@lucene.apache.org
Delivered-To: mailing list java-dev@lucene.apache.org
Received: (qmail 51727 invoked by uid 99); 30 Jul 2009 03:29:10 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jul 2009 03:29:10 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: local policy)
Received: from [208.69.42.181] (HELO radix.cryptio.net) (208.69.42.181)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jul 2009 03:29:02 +0000
Received: by radix.cryptio.net (Postfix, from userid 1007)
	id A74BF71C201; Wed, 29 Jul 2009 20:28:40 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
	by radix.cryptio.net (Postfix) with ESMTP id A413371C1E6
	for <java-dev@lucene.apache.org>; Wed, 29 Jul 2009 20:28:40 -0700 (PDT)
Date: Wed, 29 Jul 2009 20:28:40 -0700 (PDT)
From: Chris Hostetter <hossman_lucene@fucit.org>
To: java-dev@lucene.apache.org
Subject: RE: [jira] Commented: (LUCENE-1764) SampleComparable doesn't work
 well in contrib/remote tests
In-Reply-To: <D92E753356ED48EFA796936AAA348B79@VEGA>
Message-ID: <Pine.LNX.4.64.0907292024390.32304@radix.cryptio.net>
References: <2048780176.1248823274868.JavaMail.jira@brutus>
 <Pine.LNX.4.64.0907281652020.28732@radix.cryptio.net>
 <D92E753356ED48EFA796936AAA348B79@VEGA>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Checked: Checked by ClamAV on apache.org


: SortField.equals() and hashCode() contain a hint:
: 
:   /** Returns true if <code>o</code> is equal to this.  If a
:    *  {@link SortComparatorSource} (deprecated) or {@link
:    *  FieldCache.Parser} was provided, it must properly
:    *  implement equals (unless a singleton is always used). */
: 
: Maybe we should make this more visible, contain all different SortField
: comparator/parsers and place it in the the setter methods for parser and
: comparators.

SortField doesn't seem like the right place at all -- people constructing 
instances of SortField, or calling setter methods of SortField shouldn't 
have to care about this at all -- it's people who extend 
SortComparatorSource or FieldCache.Parser who need to be aware of these 
issues, so shouldn't the class level javadocs for those packages spell it 
out?

(ideally those abstract classes would declare hasCode and equals as 
abstract to *force* people to implement them ... but ship has sailed)




-Hoss


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org