Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@lucene.apache.org
Message-ID: <763024183.1247212395076.JavaMail.jira@brutus>
Date: Fri, 10 Jul 2009 00:53:15 -0700 (PDT)
From: "Ashley Sole (JIRA)" <jira@apache.org>
To: java-dev@lucene.apache.org
Subject: [jira] Issue Comment Edited: (LUCENE-1731) Allow ConstantScoreQuery
 to use custom rewrite method if using for highlighting
In-Reply-To: <1483243224.1246615307385.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729557#action_12729557 ] 

Ashley Sole edited comment on LUCENE-1731 at 7/10/09 12:51 AM:
---------------------------------------------------------------

Hi Mark,

Yeah i was aware the of the addition made but am i correct in saying this is only supported by the Solr highlighter (i.e. the "usePhraseHighlighting" params, etc)? ... Maybe i'm missing the point but i couldn't get any queries based on a TermsFilter to work with the lucene highlighter

-- Forget that, i've looked at the patches and i see how the improvement has been made. I'll just use my work around until lucene 2.9 is released but thanks for your help!

      was (Author: ashley.sole):
    Hi Mark,

Yeah i was aware the of the addition made but am i correct in saying this is only supported by the Solr highlighter (i.e. the "usePhraseHighlighting" params, etc)? ... Maybe i'm missing the point but i couldn't get any queries based on a TermsFilter to work with the lucene highlighter

-- Forget that, i've looked at the patches and i see how the improvement has been made. I'll just use my work around until lucene 2.9 is release but thanks for your help!
  
> Allow ConstantScoreQuery to use custom rewrite method if using for highlighting
> -------------------------------------------------------------------------------
>
>                 Key: LUCENE-1731
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1731
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/highlighter
>    Affects Versions: 2.4, 2.4.1
>            Reporter: Ashley Sole
>            Priority: Minor
>
> I'd like to submit a patch for ConstantScoreQuery which simply contains a setter method to state whether it is being used for highlighting or not. 
> If it is being used for highlighting, then the rewrite method can take each of the terms in the filter and create a BooleanQuery to return (if the number of terms in the filter are less than 1024), otherwise it simply uses the old rewrite method.
> This allows you to highlight upto 1024 terms when using a ConstantScoreQuery, which since it is a filter, will currently not be highlighted.
> The idea for this came from Mark Millers article "Bringing the Highlighter back to Wildcard Queries in Solr 1.4", I would just like to make it available in core lucene

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org