Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 3256 invoked from network); 17 Jul 2009 22:15:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Jul 2009 22:15:33 -0000 Received: (qmail 30838 invoked by uid 500); 17 Jul 2009 22:16:38 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 30768 invoked by uid 500); 17 Jul 2009 22:16:37 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 30760 invoked by uid 99); 17 Jul 2009 22:16:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jul 2009 22:16:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jul 2009 22:16:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 64141234C044 for ; Fri, 17 Jul 2009 15:16:15 -0700 (PDT) Message-ID: <674088211.1247868975405.JavaMail.jira@brutus> Date: Fri, 17 Jul 2009 15:16:15 -0700 (PDT) From: "Uwe Schindler (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Created: (LUCENE-1753) Make not yet final core/contrib TokenStream/Filter implementations final MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org Make not yet final core/contrib TokenStream/Filter implementations final ------------------------------------------------------------------------ Key: LUCENE-1753 URL: https://issues.apache.org/jira/browse/LUCENE-1753 Project: Lucene - Java Issue Type: Task Components: Analysis Reporter: Uwe Schindler Fix For: 3.0 Lucene's analysis package is designed in a way, that you can plug different *implementations* of analysis in chains of TokenStreams and TokenFilters. An analyzer is build of several TokenStreams/Filters that do the tokenization of text. If you want to modify the behaviour of tokenization, you implement a new subclass of TokenStream/-Filter/Tokenizer. Most classes in the core are correctly implemented like that. They are itsself final or their implementation methods are final (CharTokenizer). A lot of problems with backwards-compatibility of LUCENE-1693 are some classes in Lucene's core/contrib not yet final: - KeywordTokenizer should be declared final or its implementation methods should be final - StandardTokenizer should be declared final or its implementation methods should be final - ISOLatin1Filter is deprecated, so it will be removed in 3.0, nothing to do. CharTokenizer is the abstract base class of several other classes. The design is correct: Child classes cannot override the implementation, they can only change the behaviour of this final implementation. Contrib should be checked, that all implementation classes are at least final or they are designed in the same way like CharTokenizer. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org