Return-Path: Delivered-To: apmail-lucene-java-dev-archive@www.apache.org Received: (qmail 90029 invoked from network); 10 Jul 2009 07:31:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 10 Jul 2009 07:31:28 -0000 Received: (qmail 78312 invoked by uid 500); 10 Jul 2009 07:31:37 -0000 Delivered-To: apmail-lucene-java-dev-archive@lucene.apache.org Received: (qmail 78206 invoked by uid 500); 10 Jul 2009 07:31:37 -0000 Mailing-List: contact java-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@lucene.apache.org Delivered-To: mailing list java-dev@lucene.apache.org Received: (qmail 78198 invoked by uid 99); 10 Jul 2009 07:31:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jul 2009 07:31:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jul 2009 07:31:35 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C4B8B234C004 for ; Fri, 10 Jul 2009 00:31:14 -0700 (PDT) Message-ID: <1892406372.1247211074791.JavaMail.jira@brutus> Date: Fri, 10 Jul 2009 00:31:14 -0700 (PDT) From: "Ashley Sole (JIRA)" To: java-dev@lucene.apache.org Subject: [jira] Commented: (LUCENE-1731) Allow ConstantScoreQuery to use custom rewrite method if using for highlighting In-Reply-To: <1483243224.1246615307385.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729557#action_12729557 ] Ashley Sole commented on LUCENE-1731: ------------------------------------- Hi Mark, Yeah i was aware the of the addition made but am i correct in saying this is only supported by the Solr highlighter (i.e. the "usePhraseHighlighting" params, etc)? ... Maybe i'm missing the point but i couldn't get any queries based on a TermsFilter to work with the lucene highlighter > Allow ConstantScoreQuery to use custom rewrite method if using for highlighting > ------------------------------------------------------------------------------- > > Key: LUCENE-1731 > URL: https://issues.apache.org/jira/browse/LUCENE-1731 > Project: Lucene - Java > Issue Type: Improvement > Components: contrib/highlighter > Affects Versions: 2.4, 2.4.1 > Reporter: Ashley Sole > Priority: Minor > > I'd like to submit a patch for ConstantScoreQuery which simply contains a setter method to state whether it is being used for highlighting or not. > If it is being used for highlighting, then the rewrite method can take each of the terms in the filter and create a BooleanQuery to return (if the number of terms in the filter are less than 1024), otherwise it simply uses the old rewrite method. > This allows you to highlight upto 1024 terms when using a ConstantScoreQuery, which since it is a filter, will currently not be highlighted. > The idea for this came from Mark Millers article "Bringing the Highlighter back to Wildcard Queries in Solr 1.4", I would just like to make it available in core lucene -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org For additional commands, e-mail: java-dev-help@lucene.apache.org