lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (LUCENE-1707) Don't use ensureOpen() excessively in IndexReader and IndexWriter
Date Thu, 02 Jul 2009 13:31:48 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726475#action_12726475
] 

Shai Erera commented on LUCENE-1707:
------------------------------------

so do we need to change those back to not eol-style:native? I know Mike updated a lot of files
recently to eol-style:native (I think one of those two was updated as well). Why doesn't Hudson
encounter this problem? I've commented out the .txt line in my SVN config. Previously I didn't
have it, but I followed a page from Solr wiki (http://wiki.apache.org/solr/CommitterInfo#head-849f78497222f424339b79417056f4e510349fcb)
which recommended to put it.

I'll try to checkout again, though I'm not sure if that will help. I think we need to revert
the change that was done on r787424. I see that on r153431 (Feb 2005) the comment is "change
eol style to LF" - maybe it was for a reason? :)

> Don't use ensureOpen() excessively in IndexReader and IndexWriter
> -----------------------------------------------------------------
>
>                 Key: LUCENE-1707
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1707
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Shai Erera
>             Fix For: 2.9
>
>         Attachments: LUCENE-1707.patch, LUCENE-1707.patch
>
>
> A spin off from here: http://www.nabble.com/Excessive-use-of-ensureOpen()-td24127806.html.
> We should stop calling this method when it's not necessary for any internal Lucene code.
Currently, this code seems to hurt properly written apps, unnecessarily.
> Will post a patch soon

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org


Mime
View raw message